Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(478)

Issue 1838063002: [date] Properly handle timezones with non-ASCII characters. (Closed)

Created:
4 years, 8 months ago by Benedikt Meurer
Modified:
4 years, 8 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[date] Properly handle timezones with non-ASCII characters. The timezone part of the Date string representation might contain non-ASCII characters depending on the exact platform configuration, so we cannot safely assume that the whole date string is ASCII encoded. CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel R=yangguo@chromium.org BUG=chromium:581925 LOG=n Committed: https://crrev.com/7b342a23100d94ae0364515da2443fc1e67a64b9 Cr-Commit-Position: refs/heads/master@{#35089}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -4 lines) Patch
M src/builtins.cc View 4 chunks +20 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Benedikt Meurer
4 years, 8 months ago (2016-03-29 03:58:23 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1838063002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1838063002/1
4 years, 8 months ago (2016-03-29 03:59:57 UTC) #4
Benedikt Meurer
Hey Yang, Simple fix for non-ASCII timezones. Please take a look. Thanks, Benedikt
4 years, 8 months ago (2016-03-29 04:00:41 UTC) #5
Yang
On 2016/03/29 04:00:41, Benedikt Meurer wrote: > Hey Yang, > > Simple fix for non-ASCII ...
4 years, 8 months ago (2016-03-29 04:01:52 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1838063002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1838063002/1
4 years, 8 months ago (2016-03-29 04:03:38 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-29 05:22:40 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-03-29 05:23:52 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7b342a23100d94ae0364515da2443fc1e67a64b9
Cr-Commit-Position: refs/heads/master@{#35089}

Powered by Google App Engine
This is Rietveld 408576698