Clean up InvalidationService test infrastructure.

Clean up InvalidationService test infrastructure.

Consolidate the test support code in InvalidationServiceFactory and
compile FakeInvalidationService and P2PInvalidationService only for
tests.

BUG=chromium:269455
TEST=Compiles and passes tests.
TBR=dcheng@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255544

[Mattias Nissler (ping if slow), 2014-03-06 14:56:51]

This is a pre-factoring for https://codereview.chromium.org/179843002/ which I
broke out in order to keep the other CL focused. Please review.

[rlarocque, 2014-03-06 18:08:08]

LGTM!

I think I tried to do something like this when it was first implemented, but had
to fall back to the uglier design for some reason.  Thanks for fixing it.

https://codereview.chromium.org/183803026/diff/20001/chrome/chrome_tests_unit...
File chrome/chrome_tests_unit.gypi (right):

https://codereview.chromium.org/183803026/diff/20001/chrome/chrome_tests_unit...
chrome/chrome_tests_unit.gypi:146:
'browser/invalidation/p2p_invalidation_service.cc',
I'm surprised that this works.  I didn't know that sync_integration_tests would
be able to see these objects.

[Mattias Nissler (ping if slow), 2014-03-06 18:17:41]

https://codereview.chromium.org/183803026/diff/20001/chrome/chrome_tests_unit...
File chrome/chrome_tests_unit.gypi (right):

https://codereview.chromium.org/183803026/diff/20001/chrome/chrome_tests_unit...
chrome/chrome_tests_unit.gypi:146:
'browser/invalidation/p2p_invalidation_service.cc',
On 2014/03/06 18:08:09, rlarocque wrote:
> I'm surprised that this works.  I didn't know that sync_integration_tests
would
> be able to see these objects.

sync_integration_tests depends on test_support_sync_integration depends on
test_support_common.

[Mattias Nissler (ping if slow), 2014-03-06 18:17:45]

The CQ bit was checked by mnissler@chromium.org

[commit-bot: I haz the power, 2014-03-06 18:21:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mnissler@chromium.org/183803026/20001

[Mattias Nissler (ping if slow), 2014-03-06 18:50:23]

dcheng@ to TBR for chrome/browser/extensions/api/push_messaging/OWNERS

[commit-bot: I haz the power, 2014-03-06 19:13:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-06 19:13:21]

Retried try job too often on win_rel for step(s) app_list_unittests,
ash_unittests, aura_unittests, base_unittests, browser_tests,
cacheinvalidation_unittests, cc_unittests, check_deps, check_deps2git,
chrome_elf_unittests, chromedriver_unittests, components_unittests,
compositor_unittests, content_browsertests, content_unittests, crypto_unittests,
events_unittests, gfx_unittests, google_apis_unittests, gpu_unittests,
installer_util_unittests, interactive_ui_tests, ipc_tests, jingle_unittests,
media_unittests, mini_installer_test, nacl_integration, net_unittests,
ppapi_unittests, printing_unittests, remoting_unittests, sql_unittests,
sync_integration_tests, sync_unit_tests, telemetry_perf_unittests,
telemetry_unittests, unit_tests, views_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[Mattias Nissler (ping if slow), 2014-03-06 19:20:36]

The CQ bit was checked by mnissler@chromium.org

[commit-bot: I haz the power, 2014-03-06 19:30:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mnissler@chromium.org/183803026/20001

[commit-bot: I haz the power, 2014-03-06 21:02:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mnissler@chromium.org/183803026/20001

[dcheng, 2014-03-06 21:37:32]

chrome/browser/extensions/api/push_messaging/push_messaging_apitest.cc LGTM

[commit-bot: I haz the power, 2014-03-06 21:56:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mnissler@chromium.org/183803026/20001

[commit-bot: I haz the power, 2014-03-07 08:34:20]

Change committed as 255544