Adds support for ARMv6.

runtime/vm/assembler_arm_test.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"
 #if defined(TARGET_ARCH_ARM)
 
 #include "vm/assembler.h"
 #include "vm/cpu.h"
 #include "vm/os.h"
@@ skipping 41 matching lines @@
 
 
 ASSEMBLER_TEST_RUN(MoveRotImm, test) {
   EXPECT(test != NULL);
   typedef int (*MoveRotImm)();
   EXPECT_EQ(0x30550003, EXECUTE_TEST_CODE_INT32(MoveRotImm, test->entry()));
 }
 
 
 ASSEMBLER_TEST_GENERATE(MovImm16, assembler) {
-  __ movw(R0, 0x5678);
-  __ movt(R0, 0x1234);
+#if defined(USING_SIMULATOR)
+  // ARMv7 is the default.
+  HostCPUFeatures::set_arm_version(ARMv6);
+  __ LoadLargeImmediate(R0, 0x12345678 << 1);

[regis, 2014/03/06 17:32:11]

LoadDecodableImmediate

[zra, 2014/03/07 19:00:17]

Done.

+  HostCPUFeatures::set_arm_version(ARMv7);
+  __ movw(R1, 0x5678);
+  __ movt(R1, 0x1234);
+  __ sub(R0, R0, ShifterOperand(R1));
   __ bx(LR);
+#else
+  if (TargetCPUFeatures::arm_version() == ARMv6) {
+    __ LoadLargeImmediate(R0, 0x12345678);
+  } else {
+    ASSERT(TargetCPUFeatures::arm_version() == ARMv7);
+    __ movw(R0, 0x5678);
+    __ movt(R0, 0x1234);
+    __ bx(LR);

[regis, 2014/03/06 17:32:11]

__ bx(LR) should be outside of the branch.

Remove the version check anyway:

#else
  __ LoadDecodableImmediate(R0, 0x12345678);
  __ bx(LR);
#endif

[zra, 2014/03/07 19:00:17]

Done.

+  }
+#endif
 }
 
 
 ASSEMBLER_TEST_RUN(MovImm16, test) {
   EXPECT(test != NULL);
   typedef int (*MovImm16)();
   EXPECT_EQ(0x12345678, EXECUTE_TEST_CODE_INT32(MovImm16, test->entry()));
 }
 
 
@@ skipping 3509 matching lines @@
   __ StoreIntoObject(R2,
                      FieldAddress(R2, GrowableObjectArray::data_offset()),
                      R1);
   __ PopList((1 << CTX) | (1 << LR));
   __ Ret();
 }
 
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_ARM