Chromium Code Reviews| Index: Source/devtools/front_end/SearchableView.js |
| diff --git a/Source/devtools/front_end/SearchableView.js b/Source/devtools/front_end/SearchableView.js |
| index 7575a4cee8a0d1e4d2fbf88952c6ab56ea5c0212..a6e209c8305da14b8457e164036c102f9f48d0a2 100644 |
| --- a/Source/devtools/front_end/SearchableView.js |
| +++ b/Source/devtools/front_end/SearchableView.js |
| @@ -462,21 +462,18 @@ WebInspector.SearchableView.prototype = { |
| _updateSecondRowVisibility: function() |
| { |
| - if (this._replaceCheckboxElement.checked) { |
| - this._footerElement.classList.add("toolbar-search-replace"); |
| - this._secondRowElement.classList.remove("hidden"); |
| - this._prevButtonElement.classList.remove("hidden"); |
| - this._findButtonElement.classList.remove("hidden"); |
| - this._replaceCheckboxElement.tabIndex = -1; |
| + var secondRowVisible = this._replaceCheckboxElement.checked; |
| + this._footerElementContainer.classList.toggle("replaceable", secondRowVisible); |
| + this._footerElement.classList.toggle("toolbar-search-replace", secondRowVisible); |
| + this._secondRowElement.classList.toggle("hidden", !secondRowVisible); |
| + this._prevButtonElement.classList.toggle("hidden", !secondRowVisible); |
| + this._findButtonElement.classList.toggle("hidden", !secondRowVisible); |
| + this._replaceCheckboxElement.tabIndex = secondRowVisible ? -1 : 0; |
| + |
| + if (this._replaceCheckboxElement.checked) |
|
eustas
2014/03/04 08:07:28
why not secondRowVisible?
vsevik
2014/03/04 08:16:45
Done.
|
| this._replaceInputElement.focus(); |
| - } else { |
| - this._footerElement.classList.remove("toolbar-search-replace"); |
| - this._secondRowElement.classList.add("hidden"); |
| - this._prevButtonElement.classList.add("hidden"); |
| - this._findButtonElement.classList.add("hidden"); |
| + else |
| this._replaceCheckboxElement.tabIndex = 0; |
|
eustas
2014/03/04 08:07:28
tabIndex is already 0.
vsevik
2014/03/04 08:16:45
Great catch, I accidentally removed wrong line.
|
| - this._searchInputElement.focus(); |
| - } |
| this.doResize(); |
| }, |