DevTools: Fix replace bar appearance.

Source/devtools/front_end/SearchableView.js

 /*
  * Copyright (C) 2006, 2007, 2008 Apple Inc.  All rights reserved.
  * Copyright (C) 2007 Matt Lilek (pewtermoose@gmail.com).
  * Copyright (C) 2009 Joseph Pecoraro
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
@@ skipping 444 matching lines @@
             return;
         }
 
         this._currentQuery = query;
         this._searchProvider.currentQuery = query;
         this._searchProvider.performSearch(query, shouldJump);
     },
 
     _updateSecondRowVisibility: function()
     {
-        if (this._replaceCheckboxElement.checked) {
-            this._footerElement.classList.add("toolbar-search-replace");
-            this._secondRowElement.classList.remove("hidden");
-            this._prevButtonElement.classList.remove("hidden");
-            this._findButtonElement.classList.remove("hidden");
-            this._replaceCheckboxElement.tabIndex = -1;
+        var secondRowVisible = this._replaceCheckboxElement.checked;
+        this._footerElementContainer.classList.toggle("replaceable", secondRowVisible);
+        this._footerElement.classList.toggle("toolbar-search-replace", secondRowVisible);
+        this._secondRowElement.classList.toggle("hidden", !secondRowVisible);
+        this._prevButtonElement.classList.toggle("hidden", !secondRowVisible);
+        this._findButtonElement.classList.toggle("hidden", !secondRowVisible);
+        this._replaceCheckboxElement.tabIndex = secondRowVisible ? -1 : 0;
+
+        if (this._replaceCheckboxElement.checked)

[eustas, 2014/03/04 08:07:28]

why not secondRowVisible?

[vsevik, 2014/03/04 08:16:45]

Done.

             this._replaceInputElement.focus();
-        } else {
-            this._footerElement.classList.remove("toolbar-search-replace");
-            this._secondRowElement.classList.add("hidden");
-            this._prevButtonElement.classList.add("hidden");
-            this._findButtonElement.classList.add("hidden");
+        else
             this._replaceCheckboxElement.tabIndex = 0;

[eustas, 2014/03/04 08:07:28]

tabIndex is already 0.

[vsevik, 2014/03/04 08:16:45]

Great catch, I accidentally removed wrong line.

-            this._searchInputElement.focus();
-        }
         this.doResize();
     },
 
     _replace: function()
     {
         /** @type {!WebInspector.Replaceable} */ (this._searchProvider).replaceSelectionWith(this._replaceInputElement.value);
         delete this._currentQuery;
         this._performSearch(true, true);
     },
 
@@ skipping 48 matching lines @@
      * @param {string} text
      */
     replaceSelectionWith: function(text) { },
 
     /**
      * @param {string} query
      * @param {string} replacement
      */
     replaceAllWith: function(query, replacement) { }
 }