Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 183803018: DevTools: Fix replace bar appearance. (Closed)

Created:
6 years, 9 months ago by vsevik
Modified:
6 years, 9 months ago
Reviewers:
eustas, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

DevTools: Fix replace bar appearance. R=eustas@chromium.org, eustas, pfeldman BUG=348297 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168389

Patch Set 1 #

Total comments: 4

Patch Set 2 : Comments addressed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -13 lines) Patch
M Source/devtools/front_end/SearchableView.js View 1 1 chunk +10 lines, -13 lines 0 comments Download
M Source/devtools/front_end/inspector.css View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
vsevik
PTAL
6 years, 9 months ago (2014-03-04 08:03:41 UTC) #1
eustas
https://codereview.chromium.org/183803018/diff/1/Source/devtools/front_end/SearchableView.js File Source/devtools/front_end/SearchableView.js (right): https://codereview.chromium.org/183803018/diff/1/Source/devtools/front_end/SearchableView.js#newcode473 Source/devtools/front_end/SearchableView.js:473: if (this._replaceCheckboxElement.checked) why not secondRowVisible? https://codereview.chromium.org/183803018/diff/1/Source/devtools/front_end/SearchableView.js#newcode476 Source/devtools/front_end/SearchableView.js:476: this._replaceCheckboxElement.tabIndex = ...
6 years, 9 months ago (2014-03-04 08:07:28 UTC) #2
vsevik
https://codereview.chromium.org/183803018/diff/1/Source/devtools/front_end/SearchableView.js File Source/devtools/front_end/SearchableView.js (right): https://codereview.chromium.org/183803018/diff/1/Source/devtools/front_end/SearchableView.js#newcode473 Source/devtools/front_end/SearchableView.js:473: if (this._replaceCheckboxElement.checked) On 2014/03/04 08:07:28, eustas wrote: > why ...
6 years, 9 months ago (2014-03-04 08:16:44 UTC) #3
eustas
lgtm
6 years, 9 months ago (2014-03-04 08:21:56 UTC) #4
eustas
The CQ bit was checked by eustas@chromium.org
6 years, 9 months ago (2014-03-04 08:22:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vsevik@chromium.org/183803018/20001
6 years, 9 months ago (2014-03-04 08:23:44 UTC) #6
vsevik
6 years, 9 months ago (2014-03-04 15:01:22 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 manually as r168389 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698