Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 183803017: Revert of Ensure DOMWrapperWorld always exists in all webkit_unit_tests (Closed)

Created:
6 years, 9 months ago by apavlov
Modified:
6 years, 9 months ago
CC:
blink-reviews, shans, jsbell+idb_chromium.org, dgrogan, adamk+blink_chromium.org, Steve Block, dino_apple.com, Nils Barth (inactive), Nate Chapin, arv+blink, alancutter (OOO until 2018), marja+watch_chromium.org, alecflett, abarth-chromium, dstockwell, Timothy Loh, Eric Willigers, rjwright, sof, ericu+idb_chromium.org, darktears, haraken, kojih, jsbell+bindings_chromium.org, Mike Lawther (Google), Inactive, cmumford
Visibility:
Public.

Description

Revert of Ensure DOMWrapperWorld always exists in all webkit_unit_tests (https://codereview.chromium.org/180743013/) Reason for revert: A few inspector tests are crashing: WebCore::DOMWrapperWorld::ensureIsolatedWorld(int, int) [DOMWrapperWorld.cpp : 124 + 0x33] Original issue's description: > Ensure DOMWrapperWorld always exists in all webkit_unit_tests > > Currently DOMWrapperWorld can be 0 in some tests. This is problematic since I want to make DOMWrapperWorld::current() callable from anywhere. Thus this CL adds DOMWrapperWorld to all webkit_unit_tests. > > - It's verbose to initialize v8::HandleScope, v8::Context, v8::Context::Scope, V8PerContextData and DOMWrapperWorld in each test. So this CL adds a helper class (V8BindingTestScope) that does all the initialization work. > > - This CL also fixes indentation of V8Binding.h. > > BUG=341032 > NOTRY=true > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168355 TBR=jochen@chromium.org,dcarney@chromium.org,haraken@chromium.org NOTREECHECKS=true NOTRY=true BUG=341032 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168369

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+739 lines, -742 lines) Patch
M Source/bindings/v8/DOMWrapperWorld.h View 2 chunks +2 lines, -3 lines 0 comments Download
M Source/bindings/v8/DOMWrapperWorld.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/IDBBindingUtilitiesTest.cpp View 1 chunk +5 lines, -2 lines 0 comments Download
M Source/bindings/v8/ScriptPromiseResolverTest.cpp View 3 chunks +10 lines, -4 lines 0 comments Download
M Source/bindings/v8/ScriptPromiseTest.cpp View 2 chunks +10 lines, -5 lines 0 comments Download
M Source/bindings/v8/V8Binding.h View 1 chunk +662 lines, -672 lines 0 comments Download
M Source/bindings/v8/V8Binding.cpp View 1 chunk +0 lines, -14 lines 0 comments Download
M Source/bindings/v8/WorkerScriptController.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/AnimationTest.cpp View 9 chunks +25 lines, -23 lines 0 comments Download
M Source/core/animation/AnimationTimingInputTest.cpp View 4 chunks +15 lines, -13 lines 0 comments Download
M Source/modules/indexeddb/IDBRequestTest.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M Source/modules/indexeddb/IDBTransactionTest.cpp View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
apavlov
Created Revert of Ensure DOMWrapperWorld always exists in all webkit_unit_tests
6 years, 9 months ago (2014-03-04 07:59:30 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/apavlov@chromium.org/183803017/1
6 years, 9 months ago (2014-03-04 07:59:51 UTC) #2
commit-bot: I haz the power
6 years, 9 months ago (2014-03-04 08:00:14 UTC) #3
Message was sent while issue was closed.
Change committed as 168369

Powered by Google App Engine
This is Rietveld 408576698