Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Issue 183803016: Rename ^ and ^^ combinator to /shadow-all/ and /shadow-deep/. (Closed)

Created:
6 years, 9 months ago by tasak
Modified:
6 years, 9 months ago
Reviewers:
dglazkov
CC:
blink-reviews, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis
Visibility:
Public.

Description

Rename ^ and ^^ combinator to /shadow-all/ and /shadow-deep/. c.f. shadow-styling spec: /shadow-all/: http://dev.w3.org/csswg/shadow-styling/#shadow-all-combinator /shadow-deep/: http://dev.w3.org/csswg/shadow-styling/#shadow-deep-combinator BUG=348891 TEST=Replaced all ^ and ^^ with /shadow-all/ and /shadow-deep/ and rebaselined. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168454

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -111 lines) Patch
M LayoutTests/fast/dom/shadow/cascade-of-treeboundary-crossing-rules.html View 2 chunks +3 lines, -3 lines 0 comments Download
M LayoutTests/fast/dom/shadow/content-pseudo-element-with-cat.html View 6 chunks +7 lines, -7 lines 0 comments Download
M LayoutTests/fast/dom/shadow/content-pseudo-element-with-cat-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/shadow/content-pseudo-element-with-hat.html View 5 chunks +5 lines, -5 lines 0 comments Download
M LayoutTests/fast/dom/shadow/content-pseudo-element-with-hat-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/shadow/dynamically-added-cat-hat-rules.html View 1 chunk +4 lines, -4 lines 0 comments Download
M LayoutTests/fast/dom/shadow/scrollbar.html View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/dom/shadow/shadow-and-list-elements.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/shadow/shadow-dom-event-dispatching-distributed-to-younger.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/shadow/shadowdom-reprojection-1.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/shadow/shadowdom-reprojection-2.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/shadow/style-with-cat.html View 22 chunks +38 lines, -38 lines 0 comments Download
M LayoutTests/fast/dom/shadow/style-with-cat-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/shadow/style-with-hat.html View 16 chunks +24 lines, -24 lines 0 comments Download
M LayoutTests/fast/dom/shadow/style-with-hat-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSGrammar.y View 1 chunk +8 lines, -6 lines 0 comments Download
M Source/core/css/CSSSelector.h View 1 chunk +4 lines, -3 lines 0 comments Download
M Source/core/css/CSSSelector.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/css/CSSSelectorList.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/RuleFeature.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/SelectorChecker.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/SelectorFilter.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/StyleInvalidationAnalysis.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
tasak
6 years, 9 months ago (2014-03-04 06:33:39 UTC) #1
dglazkov
I like your idea of adding this next to cat/hat for now. Can we adopt ...
6 years, 9 months ago (2014-03-04 17:21:10 UTC) #2
dglazkov
lgtm, probably should rename the test names, too. Could be done in a different patch.
6 years, 9 months ago (2014-03-04 22:04:06 UTC) #3
tasak
On 2014/03/04 22:04:06, Dimitri Glazkov wrote: > lgtm, probably should rename the test names, too. ...
6 years, 9 months ago (2014-03-05 03:14:00 UTC) #4
tasak
The CQ bit was checked by tasak@google.com
6 years, 9 months ago (2014-03-05 03:14:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tasak@google.com/183803016/20001
6 years, 9 months ago (2014-03-05 03:14:22 UTC) #6
commit-bot: I haz the power
6 years, 9 months ago (2014-03-05 08:56:06 UTC) #7
Message was sent while issue was closed.
Change committed as 168454

Powered by Google App Engine
This is Rietveld 408576698