|
|
Created:
6 years, 9 months ago by r.c.ladan Modified:
6 years, 9 months ago CC:
chromium-reviews, Paweł Hajdan Jr. Base URL:
https://chromium.googlesource.com/chromium/src.git@master Visibility:
Public. |
DescriptionAdd a config.h for FreeBSD, generated by running "../configure" in third_party/libevent/freebsd/ on a FreeBSD 10.0-amd64 system.
For 32-bit FreeBSD systems, SIZEOF_LONG would be 4, but since both systems
have a strtoll() function this does not matter (see libevent/evutil.c).
Taking 8 for SIZEOF_LONG is also in sync with _EVENT_SIZEOF_LONG as
defined in libevent/freebsd/event-config.h
BUG=350396
TBR=cpu
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255766
Patch Set 1 #
Messages
Total messages: 25 (0 generated)
only new libraries need owners review. For your change just find somebody who cares about the change and then TBR=cpu
Paweł , could you care for this issue?
LGTM
The CQ bit was checked by r.c.ladan@gmail.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/r.c.ladan@gmail.com/183803011/1
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/r.c.ladan@gmail.com/183803011/1
The CQ bit was unchecked by commit-bot@chromium.org
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...
TBR=cpu
The CQ bit was checked by r.c.ladan@gmail.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/r.c.ladan@gmail.com/183803011/1
The CQ bit was unchecked by commit-bot@chromium.org
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...
On 2014/03/06 08:04:12, I haz the power (commit-bot) wrote: > Retried try job too often on chromium_presubmit for step(s) presubmit > http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p... It looks like the commit-bot really wants explicit approval, setting tbr does not seem to work.
the TBR goes in the CL description. Also set BUG=none if you don't have a bug but I encourage you to create a bug in crbug.com. Please carefully read this for other things you should know: http://www.chromium.org/developers/contributing-code
The CQ bit was checked by r.c.ladan@gmail.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/r.c.ladan@gmail.com/183803011/1
The CQ bit was unchecked by commit-bot@chromium.org
Retried try job too often on win_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...
The CQ bit was checked by r.c.ladan@gmail.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/r.c.ladan@gmail.com/183803011/1
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/r.c.ladan@gmail.com/183803011/1
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/r.c.ladan@gmail.com/183803011/1
Message was sent while issue was closed.
Change committed as 255766 |