Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issue 183803011: Add a config.h for FreeBSD, generated by running "../configure" in third_party/libevent/freebsd/ on… (Closed)

Created:
6 years, 9 months ago by r.c.ladan
Modified:
6 years, 9 months ago
CC:
chromium-reviews, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Add a config.h for FreeBSD, generated by running "../configure" in third_party/libevent/freebsd/ on a FreeBSD 10.0-amd64 system. For 32-bit FreeBSD systems, SIZEOF_LONG would be 4, but since both systems have a strtoll() function this does not matter (see libevent/evutil.c). Taking 8 for SIZEOF_LONG is also in sync with _EVENT_SIZEOF_LONG as defined in libevent/freebsd/event-config.h BUG=350396 TBR=cpu Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255766

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
A + third_party/libevent/freebsd/config.h View 3 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 25 (0 generated)
r.c.ladan
6 years, 9 months ago (2014-03-03 13:58:40 UTC) #1
cpu_(ooo_6.6-7.5)
only new libraries need owners review. For your change just find somebody who cares about ...
6 years, 9 months ago (2014-03-03 22:15:17 UTC) #2
r.c.ladan
Paweł , could you care for this issue?
6 years, 9 months ago (2014-03-03 22:20:04 UTC) #3
Paweł Hajdan Jr.
LGTM
6 years, 9 months ago (2014-03-05 23:34:07 UTC) #4
r.c.ladan
The CQ bit was checked by r.c.ladan@gmail.com
6 years, 9 months ago (2014-03-05 23:39:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/r.c.ladan@gmail.com/183803011/1
6 years, 9 months ago (2014-03-05 23:41:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/r.c.ladan@gmail.com/183803011/1
6 years, 9 months ago (2014-03-06 00:19:09 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-06 00:49:30 UTC) #8
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=53767
6 years, 9 months ago (2014-03-06 00:49:31 UTC) #9
r.c.ladan
TBR=cpu
6 years, 9 months ago (2014-03-06 07:20:53 UTC) #10
r.c.ladan
The CQ bit was checked by r.c.ladan@gmail.com
6 years, 9 months ago (2014-03-06 07:27:51 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/r.c.ladan@gmail.com/183803011/1
6 years, 9 months ago (2014-03-06 07:28:07 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-06 08:04:12 UTC) #13
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=53815
6 years, 9 months ago (2014-03-06 08:04:12 UTC) #14
r.c.ladan
On 2014/03/06 08:04:12, I haz the power (commit-bot) wrote: > Retried try job too often ...
6 years, 9 months ago (2014-03-06 10:13:51 UTC) #15
cpu_(ooo_6.6-7.5)
the TBR goes in the CL description. Also set BUG=none if you don't have a ...
6 years, 9 months ago (2014-03-06 18:57:12 UTC) #16
r.c.ladan
The CQ bit was checked by r.c.ladan@gmail.com
6 years, 9 months ago (2014-03-07 13:50:13 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/r.c.ladan@gmail.com/183803011/1
6 years, 9 months ago (2014-03-07 13:50:37 UTC) #18
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-07 15:22:19 UTC) #19
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=277407
6 years, 9 months ago (2014-03-07 15:22:20 UTC) #20
r.c.ladan
The CQ bit was checked by r.c.ladan@gmail.com
6 years, 9 months ago (2014-03-07 19:29:26 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/r.c.ladan@gmail.com/183803011/1
6 years, 9 months ago (2014-03-07 19:32:12 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/r.c.ladan@gmail.com/183803011/1
6 years, 9 months ago (2014-03-07 20:27:41 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/r.c.ladan@gmail.com/183803011/1
6 years, 9 months ago (2014-03-08 10:54:28 UTC) #24
commit-bot: I haz the power
6 years, 9 months ago (2014-03-08 12:11:54 UTC) #25
Message was sent while issue was closed.
Change committed as 255766

Powered by Google App Engine
This is Rietveld 408576698