Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Unified Diff: media/cast/net/cast_transport_sender_impl.cc

Issue 1837993002: Add log to detect the out of order RTCP packets. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/cast/net/cast_transport_sender_impl.cc
diff --git a/media/cast/net/cast_transport_sender_impl.cc b/media/cast/net/cast_transport_sender_impl.cc
index 5f46089bd0a4c1c8132b4e50c021007aedb9d60b..ddc55b99aa977041b89caff7b697dc111a17d0f6 100644
--- a/media/cast/net/cast_transport_sender_impl.cc
+++ b/media/cast/net/cast_transport_sender_impl.cc
@@ -374,12 +374,10 @@ void CastTransportSenderImpl::OnReceivedCastMessage(
}
if (!cast_message.missing_frames_and_packets.empty()) {
- // This call does two things.
- // 1. Specifies that retransmissions for packets not listed in the set are
- // cancelled.
- // 2. Specifies a deduplication window. For video this would be the most
- // recent RTT. For audio there is no deduplication.
- ResendPackets(ssrc, cast_message.missing_frames_and_packets, true,
+ VLOG(2) << "feedback_count: " << cast_message.feedback_count;
+ // This call specifies a deduplication window. For video this would be the
+ // most recent RTT. For audio there is no deduplication.
+ ResendPackets(ssrc, cast_message.missing_frames_and_packets, false,
miu 2016/03/29 19:14:14 Looks like all possible callers of ResendPackets w
xjz 2016/03/29 19:33:49 As discussed, this is not applicable any more.
dedup_info);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698