Add log to detect the out of order RTCP packets.

Add log to detect the out of order RTCP packets.

BUG=

Committed: https://crrev.com/4d0525ae365a84569dfd7fb9e583f3fb41d89a70
Cr-Commit-Position: refs/heads/master@{#383818}

[xjz, 2016-03-28 23:42:26]

xjz@chromium.org changed reviewers:
+ miu@chromium.org

[xjz, 2016-03-28 23:42:27]

PTAL

[miu, 2016-03-29 19:14:14]

https://codereview.chromium.org/1837993002/diff/1/media/cast/net/cast_transpo...
File media/cast/net/cast_transport_sender_impl.cc (right):

https://codereview.chromium.org/1837993002/diff/1/media/cast/net/cast_transpo...
media/cast/net/cast_transport_sender_impl.cc:380: ResendPackets(ssrc,
cast_message.missing_frames_and_packets, false,
Looks like all possible callers of ResendPackets will now pass |false| as the
3rd argument.  So, can you also remove the 3rd argument and the extra code in
CTSImpl::ResendPackets() (and RtpSender::ResendPackets())?

[xjz, 2016-03-29 19:32:44]

Description was changed from

==========
Don't cancel resending packets that are not in the NACK list.
The NACKs from receiver might be out of order, the packets that are
not in the |missing_frames_and_packets| list may not indicate that
they were received.

BUG=
==========

to

==========
Add log to detect the out of order RTCP packets.

BUG=
==========

[xjz, 2016-03-29 19:33:49]

Revert the change on canceling resending the acked packets. PTAL.

https://codereview.chromium.org/1837993002/diff/1/media/cast/net/cast_transpo...
File media/cast/net/cast_transport_sender_impl.cc (right):

https://codereview.chromium.org/1837993002/diff/1/media/cast/net/cast_transpo...
media/cast/net/cast_transport_sender_impl.cc:380: ResendPackets(ssrc,
cast_message.missing_frames_and_packets, false,
On 2016/03/29 19:14:14, miu wrote:
> Looks like all possible callers of ResendPackets will now pass |false| as the
> 3rd argument.  So, can you also remove the 3rd argument and the extra code in
> CTSImpl::ResendPackets() (and RtpSender::ResendPackets())?

As discussed, this is not applicable any more.

[miu, 2016-03-29 20:11:35]

The CQ bit was checked by miu@chromium.org

[miu, 2016-03-29 20:11:36]

lgtm

[commit-bot: I haz the power, 2016-03-29 20:12:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1837993002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1837993002/20001

[commit-bot: I haz the power, 2016-03-29 20:57:04]

Description was changed from

==========
Add log to detect the out of order RTCP packets.

BUG=
==========

to

==========
Add log to detect the out of order RTCP packets.

BUG=
==========

[commit-bot: I haz the power, 2016-03-29 20:57:05]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-29 20:58:41]

Description was changed from

==========
Add log to detect the out of order RTCP packets.

BUG=
==========

to

==========
Add log to detect the out of order RTCP packets.

BUG=

Committed: https://crrev.com/4d0525ae365a84569dfd7fb9e583f3fb41d89a70
Cr-Commit-Position: refs/heads/master@{#383818}
==========

[commit-bot: I haz the power, 2016-03-29 20:58:43]

Patchset 2 (id:??) landed as
https://crrev.com/4d0525ae365a84569dfd7fb9e583f3fb41d89a70
Cr-Commit-Position: refs/heads/master@{#383818}