Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(510)

Issue 1837963003: Remove document mode opt-out promo. (Closed)

Created:
4 years, 8 months ago by newt (away)
Modified:
4 years, 8 months ago
Reviewers:
Mark P, gone
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove document mode opt-out promo. BUG=582539 Committed: https://crrev.com/e5178bee779e142875133b5f1fecd9a1a4946cb5 Cr-Commit-Position: refs/heads/master@{#383835}

Patch Set 1 #

Patch Set 2 : fixed lint #

Patch Set 3 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -384 lines) Patch
M build/android/lint/suppressions.xml View 1 1 chunk +1 line, -1 line 0 comments Download
D chrome/android/java/res/drawable-mdpi/tabs_moved_htc.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-mdpi/tabs_moved_nexus.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-mdpi/tabs_moved_samsung.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xxhdpi/tabs_moved_htc.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xxhdpi/tabs_moved_nexus.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xxhdpi/tabs_moved_samsung.png View Binary file 0 comments Download
M chrome/android/java/res/layout/new_tab_page.xml View 1 chunk +0 lines, -8 lines 0 comments Download
D chrome/android/java/res/layout/opt_out_promo.xml View 1 chunk +0 lines, -55 lines 0 comments Download
M chrome/android/java/res/values/colors.xml View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/document/DocumentMetricIds.java View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java View 8 chunks +1 line, -51 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageLayout.java View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java View 9 chunks +0 lines, -76 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/preferences/DocumentModeManager.java View 5 chunks +0 lines, -175 lines 0 comments Download
M chrome/android/java/strings/android_chrome_strings.grd View 1 2 1 chunk +0 lines, -9 lines 0 comments Download
M tools/metrics/actions/actions.xml View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (11 generated)
newt (away)
PTAL
4 years, 8 months ago (2016-03-29 18:35:25 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1837963003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1837963003/1
4 years, 8 months ago (2016-03-29 18:36:34 UTC) #4
newt (away)
+mpearson for actions.xml
4 years, 8 months ago (2016-03-29 18:38:37 UTC) #6
Mark P
actions.xml lgtm
4 years, 8 months ago (2016-03-29 18:42:25 UTC) #7
gone
lgtm
4 years, 8 months ago (2016-03-29 18:45:12 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clang_dbg_recipe/builds/41942) linux_android_rel_ng on ...
4 years, 8 months ago (2016-03-29 18:53:27 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1837963003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1837963003/20001
4 years, 8 months ago (2016-03-29 19:03:33 UTC) #13
commit-bot: I haz the power
Failed to apply patch for chrome/android/java/res/values/colors.xml: While running git apply --index -3 -p1; error: patch ...
4 years, 8 months ago (2016-03-29 20:15:43 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1837963003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1837963003/40001
4 years, 8 months ago (2016-03-29 20:28:24 UTC) #19
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-03-29 21:37:43 UTC) #20
commit-bot: I haz the power
4 years, 8 months ago (2016-03-29 21:38:49 UTC) #22
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/e5178bee779e142875133b5f1fecd9a1a4946cb5
Cr-Commit-Position: refs/heads/master@{#383835}

Powered by Google App Engine
This is Rietveld 408576698