Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issue 1837963002: Use fallback in LayoutThemeMobile on mac. (Closed)

Created:
4 years, 8 months ago by dgozman
Modified:
4 years, 8 months ago
Reviewers:
pdr.
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use fallback in LayoutThemeMobile on mac. WebThemeEngine does nothing on mac, so we use fallback to paint radio and checkbox. This only happens when emulating mobile device on mac. BUG=591315 Committed: https://crrev.com/9f52d372f849394e43bb2e648750311442a029e3 Cr-Commit-Position: refs/heads/master@{#385205}

Patch Set 1 #

Patch Set 2 : test #

Messages

Total messages: 16 (6 generated)
dgozman
Take a look please.
4 years, 8 months ago (2016-03-28 22:19:12 UTC) #2
dgozman
@pdr: could you please take a look? This is a follow up to https://codereview.chromium.org/1690493002/
4 years, 8 months ago (2016-04-04 20:32:35 UTC) #4
pdr.
On 2016/04/04 at 20:32:35, dgozman wrote: > @pdr: could you please take a look? This ...
4 years, 8 months ago (2016-04-04 20:34:06 UTC) #5
dgozman
On 2016/04/04 20:34:06, pdr wrote: > On 2016/04/04 at 20:32:35, dgozman wrote: > > @pdr: ...
4 years, 8 months ago (2016-04-05 04:57:32 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1837963002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1837963002/20001
4 years, 8 months ago (2016-04-05 04:57:58 UTC) #8
pdr.
Thanks, LGTM
4 years, 8 months ago (2016-04-05 05:04:05 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-05 06:05:01 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1837963002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1837963002/20001
4 years, 8 months ago (2016-04-05 17:16:56 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-05 17:23:14 UTC) #14
commit-bot: I haz the power
4 years, 8 months ago (2016-04-05 17:24:46 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9f52d372f849394e43bb2e648750311442a029e3
Cr-Commit-Position: refs/heads/master@{#385205}

Powered by Google App Engine
This is Rietveld 408576698