Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(870)

Unified Diff: chrome/tools/build/win/create_installer_archive.py

Issue 1837943002: Make missing or misspelled DLLs a build-time failure (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/tools/build/win/create_installer_archive.py
diff --git a/chrome/tools/build/win/create_installer_archive.py b/chrome/tools/build/win/create_installer_archive.py
index 313af85660b0d4fc6c8a33fadaa5c164c9e3efa2..78a621aa83014f48b2b0b9baddceb7e719e84f4d 100755
--- a/chrome/tools/build/win/create_installer_archive.py
+++ b/chrome/tools/build/win/create_installer_archive.py
@@ -519,6 +519,9 @@ def DoComponentBuildTasks(staging_dir, build_dir, target_arch, current_version):
for setup_component_dll_glob in setup_component_dll_globs:
setup_component_dlls = glob.glob(os.path.join(build_dir,
setup_component_dll_glob))
+ if len(setup_component_dlls) == 0:
+ raise Exception('No matching DLL found for "%s" pattern.' %
robertshield 2016/03/29 03:03:29 optional nit: this is likely to show up for a dev
+ setup_component_dll_glob)
for setup_component_dll in setup_component_dlls:
g_archive_inputs.append(setup_component_dll)
shutil.copy(setup_component_dll, installer_dir)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698