App windows on ChromeOS cannot be sized to their maximum height

ash/wm/custom_frame_view_ash.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/wm/custom_frame_view_ash.h"
 
 #include "ash/ash_switches.h"
 #include "ash/wm/caption_buttons/frame_caption_button_container_view.h"
 #include "ash/wm/caption_buttons/frame_maximize_button.h"
 #include "ash/wm/caption_buttons/frame_maximize_button_observer.h"
@@ skipping 457 matching lines @@
 }
 
 gfx::Size CustomFrameViewAsh::GetMinimumSize() {
   gfx::Size min_client_view_size(frame_->client_view()->GetMinimumSize());
   return gfx::Size(
       std::max(header_view_->GetMinimumWidth(), min_client_view_size.width()),
       NonClientTopBorderHeight() + min_client_view_size.height());
 }
 
 gfx::Size CustomFrameViewAsh::GetMaximumSize() {
-  return frame_->client_view()->GetMaximumSize();
+  gfx::Size max_client_size(frame_->client_view()->GetMaximumSize());
+  return gfx::Size(
+      max_client_size.width() == 0
+          ? 0
+          : std::max(header_view_->GetMinimumWidth(), max_client_size.width()),
+      max_client_size.height() == 0
+          ? 0
+          : NonClientTopBorderHeight() + max_client_size.height());

[pkotwicz, 2014/03/07 01:45:14]

Optional Nit: This might be easier to read

int width = 0;
int height = 0;
if (max_client_size.width() > 0) {
  width = std::max(header_view_->GetMinimumWidth(), max_client_size.width());
}
if (max_client_size.height() > 0)
  height = NonClientTopBorderHeight() + max_client_size.height();

return gfx::Size(width, height);

Otherwise, LGTM

[tmdiep, 2014/03/07 02:08:35]

Done.

 }
 
 void CustomFrameViewAsh::SchedulePaintInRect(const gfx::Rect& r) {
   // We may end up here before |header_view_| has been added to the Widget.
   if (header_view_->GetWidget()) {
     // The HeaderView is not a child of CustomFrameViewAsh. Redirect the paint
     // to HeaderView instead.
     gfx::RectF to_paint(r);
     views::View::ConvertRectToTarget(this, header_view_, &to_paint);
     header_view_->SchedulePaintInRect(gfx::ToEnclosingRect(to_paint));
@@ skipping 13 matching lines @@
 }
 
 ////////////////////////////////////////////////////////////////////////////////
 // CustomFrameViewAsh, private:
 
 int CustomFrameViewAsh::NonClientTopBorderHeight() const {
   return frame_->IsFullscreen() ? 0 : header_view_->GetPreferredHeight();
 }
 
 }  // namespace ash