third_party/oauth2client/MODIFICATIONS.diff - Issue 183793010: Added OAuth2 authentication to apply_issue

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/oauth2client/MODIFICATIONS.diff

Issue 183793010: Added OAuth2 authentication to apply_issue (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Patch Set: Fixed README Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 diff --git a/third_party/oauth2client/client.py b/third_party/oauth2client/clien t.py

	2 index cd03e38..d82c848 100644

	3 --- a/third_party/oauth2client/client.py

	4 +++ b/third_party/oauth2client/client.py

	5 @@ -23,9 +23,8 @@ import base64

	6 import clientsecrets

	7 import copy

	8 import datetime

	9 -import httplib2

	10 +from .. import httplib2

	11 import logging

	12 -import os

	13 import sys

	14 import time

	15 import urllib

	16 @@ -35,9 +34,9 @@ from anyjson import simplejson

	17

	18 HAS_OPENSSL = False

	19 try:

	20 - from oauth2client.crypt import Signer
	Vadim Sh. 2014/03/14 18:56:47 I'm sorry for being extra pedantic, but IIUC this I'm sorry for being extra pedantic, but IIUC this diff doesn't apply to version 1.2. See https://code.google.com/p/google-api-python-client/source/browse/oauth2client... It doesn't have 'from oauth2client.crypt import Signer' etc lines... My end goal here is to simplify update of oauth2client in the future to: 1. Checkout a new version of oauth2client from it's home repo. 2. Apply diff and other mentioned modifications. 3. Copy to third_party/ 4. ... 5. Profit! For this to be easy, README.chromium should provide a reproducible way to get the source that's in third_party/: i.e. checkout some specified revision, from specified repository, apply diff and get code that is exact copy of what is in third_party/ now. Sorry again for being stubborn.
	21 - from oauth2client.crypt import make_signed_jwt

	22 - from oauth2client.crypt import verify_signed_jwt_with_certs

	23 + from .crypt import Signer

	24 + from .crypt import make_signed_jwt

	25 + from .crypt import verify_signed_jwt_with_certs

	26 HAS_OPENSSL = True

	27 except ImportError:

	28 pass

OLD	NEW

« no previous file with comments | « third_party/oauth2client/LICENSE ('k') | third_party/oauth2client/README.chromium » ('j') | no next file with comments »