Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Unified Diff: content/browser/download/download_browsertest.cc

Issue 1837913002: Disable a couple of downloads that are tests failing on Windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/download/download_browsertest.cc
diff --git a/content/browser/download/download_browsertest.cc b/content/browser/download/download_browsertest.cc
index 75c37d61dc17d6210a21d38152440e78aac071b5..4e11001c77eb6589040d62cc222abb2159ff7c01 100644
--- a/content/browser/download/download_browsertest.cc
+++ b/content/browser/download/download_browsertest.cc
@@ -1071,7 +1071,13 @@ IN_PROC_BROWSER_TEST_F(DownloadContentTest, StrongValidators) {
// Resumption should only attempt to contact the final URL if the download has a
// URL chain.
-IN_PROC_BROWSER_TEST_F(DownloadContentTest, DISABLED_RedirectBeforeResume) {
+#if defined(OS_WIN)
+// Failing on Windows. http://crbug.com/598264
+#define MAYBE_RedirectBeforeResume DISABLED_RedirectBeforeResume
+#else
+#define MAYBE_RedirectBeforeResume RedirectBeforeResume
+#endif
+IN_PROC_BROWSER_TEST_F(DownloadContentTest, MAYBE_RedirectBeforeResume) {
TestDownloadRequestHandler request_handler_1(
GURL("http://example.com/first-url"));
request_handler_1.StartServingStaticResponse(
@@ -1125,7 +1131,13 @@ IN_PROC_BROWSER_TEST_F(DownloadContentTest, DISABLED_RedirectBeforeResume) {
// If a resumption request results in a redirect, the response should be ignored
// and the download should be marked as interrupted again.
-IN_PROC_BROWSER_TEST_F(DownloadContentTest, RedirectWhileResume) {
+#if defined(OS_WIN)
+// Failing on Windows. http://crbug.com/598264
+#define MAYBE_RedirectWhileResume DISABLED_RedirectWhileResume
+#else
+#define MAYBE_RedirectWhileResume RedirectWhileResume
+#endif
+IN_PROC_BROWSER_TEST_F(DownloadContentTest, MAYBE_RedirectWhileResume) {
TestDownloadRequestHandler request_handler(
GURL("http://example.com/first-url"));
TestDownloadRequestHandler::Parameters parameters =
@@ -1187,7 +1199,13 @@ IN_PROC_BROWSER_TEST_F(DownloadContentTest, RedirectWhileResume) {
// not the range that was requested or an invalid or missing Content-Range
// header), then the download should be marked as interrupted again without
// discarding the partial state.
-IN_PROC_BROWSER_TEST_F(DownloadContentTest, BadRangeHeader) {
+#if defined(OS_WIN)
+// Failing on Windows. http://crbug.com/598264
+#define MAYBE_BadRangeHeader DISABLED_BadRangeHeader
+#else
+#define MAYBE_BadRangeHeader BadRangeHeader
+#endif
+IN_PROC_BROWSER_TEST_F(DownloadContentTest, MAYBE_BadRangeHeader) {
TestDownloadRequestHandler request_handler;
TestDownloadRequestHandler::Parameters parameters =
TestDownloadRequestHandler::Parameters::WithSingleInterruption();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698