Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1837893004:
Add unit repeat tiler (Closed)
DescriptionAdd unit repeat tiler.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1837893004
Committed: https://skia.googlesource.com/skia/+/865a289bfec169cb19970c734e9aa855c267f060
Patch Set 1 #Patch Set 2 : sync #Patch Set 3 : guard empty span #
Total comments: 3
Patch Set 4 : Address florin's comments. #
Messages
Total messages: 23 (10 generated)
Description was changed from ========== Add unit repeat tiler. BUG=skia: ========== to ========== Add unit repeat tiler. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
The CQ bit was checked by herb@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1837893004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1837893004/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)
sync
guard empty span
The CQ bit was checked by herb@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1837893004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1837893004/40001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Add unit repeat tiler. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Add unit repeat tiler. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
herb@google.com changed reviewers: + fmalita@chromium.org, mtklein@google.com
lgtm https://codereview.chromium.org/1837893004/diff/40001/src/core/SkLinearBitmap... File src/core/SkLinearBitmapPipeline_tile.h (right): https://codereview.chromium.org/1837893004/diff/40001/src/core/SkLinearBitmap... src/core/SkLinearBitmapPipeline_tile.h:245: void tileXPoints(Sk4s* xs) { I'm a bit behind on this - why Sk4s and not Sk4f? https://codereview.chromium.org/1837893004/diff/40001/src/core/SkLinearBitmap... src/core/SkLinearBitmapPipeline_tile.h:280: if (!span.isEmpty()) { Nit: I would write this as an early return to unnest the rest.
https://codereview.chromium.org/1837893004/diff/40001/src/core/SkLinearBitmap... File src/core/SkLinearBitmapPipeline_tile.h (right): https://codereview.chromium.org/1837893004/diff/40001/src/core/SkLinearBitmap... src/core/SkLinearBitmapPipeline_tile.h:245: void tileXPoints(Sk4s* xs) { On 2016/03/31 at 13:58:19, f(malita) wrote: > I'm a bit behind on this - why Sk4s and not Sk4f? It parallels SkScalar. Imagine if SkScalar were double... Sk4f would not be appropriate to use, but Sk4s would be. The definition of Sk4s is literally typedef SkNx<4, SkScalar> Sk4s;
Address florin's comments.
The CQ bit was checked by herb@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from fmalita@chromium.org Link to the patchset: https://codereview.chromium.org/1837893004/#ps60001 (title: "Address florin's comments.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1837893004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1837893004/60001
Message was sent while issue was closed.
Description was changed from ========== Add unit repeat tiler. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Add unit repeat tiler. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/865a289bfec169cb19970c734e9aa855c267f060 ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as https://skia.googlesource.com/skia/+/865a289bfec169cb19970c734e9aa855c267f060
Message was sent while issue was closed.
A revert of this CL (patchset #4 id:60001) has been created in https://codereview.chromium.org/1844713005/ by robertphillips@google.com. The reason for reverting is: ASAN bot failures. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
