Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2413)

Unified Diff: content/renderer/dom_storage/local_storage_cached_area.h

Issue 1837883003: Some fleshing out the mojo based localstorage implementation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/dom_storage/local_storage_cached_area.h
diff --git a/content/renderer/dom_storage/local_storage_cached_area.h b/content/renderer/dom_storage/local_storage_cached_area.h
index 27977699e744fe2fc489f6b5f55dd1085195a12a..ba126fca792423ee40246928212b197fa17f2fbe 100644
--- a/content/renderer/dom_storage/local_storage_cached_area.h
+++ b/content/renderer/dom_storage/local_storage_cached_area.h
@@ -65,6 +65,9 @@ class LocalStorageCachedArea : public mojom::LevelDBObserver,
~LocalStorageCachedArea() override;
// LevelDBObserver:
+ void KeyAdded(mojo::Array<uint8_t> key,
+ mojo::Array<uint8_t> value,
+ const mojo::String& source) override;
void KeyChanged(mojo::Array<uint8_t> key,
mojo::Array<uint8_t> new_value,
mojo::Array<uint8_t> old_value,
@@ -73,16 +76,21 @@ class LocalStorageCachedArea : public mojom::LevelDBObserver,
mojo::Array<uint8_t> old_value,
const mojo::String& source) override;
void AllDeleted(const mojo::String& source) override;
+ void GetAllComplete(uint64_t request_id) override;
+
+ // Common helper for KeyAdded() and KeyChanged()
+ void KeyAddedOrChanged(mojo::Array<uint8_t> key,
+ mojo::Array<uint8_t> new_value,
+ base::NullableString16& old_value,
+ const mojo::String& source);
// Synchronously fetches the origin's local storage data if it hasn't been
// fetched already.
void EnsureLoaded();
- void OnSetItemComplete(const base::string16& key,
- leveldb::DatabaseError result);
- void OnRemoveItemComplete(const base::string16& key,
- leveldb::DatabaseError result);
- void OnClearComplete(leveldb::DatabaseError result);
+ void OnSetItemComplete(const base::string16& key, bool success);
+ void OnRemoveItemComplete(const base::string16& key, bool success);
+ void OnClearComplete(bool success);
// Resets the object back to its newly constructed state.
void Reset();
@@ -90,10 +98,13 @@ class LocalStorageCachedArea : public mojom::LevelDBObserver,
url::Origin origin_;
scoped_refptr<DOMStorageMap> map_;
std::map<base::string16, int> ignore_key_mutations_;
+ bool ignore_all_mutations_ = false;
+ uint64_t get_all_request_id_ = UINT64_C(0);
mojom::LevelDBWrapperPtr leveldb_;
mojo::Binding<mojom::LevelDBObserver> binding_;
LocalStorageCachedAreas* cached_areas_;
std::map<std::string, LocalStorageArea*> areas_;
+ base::WeakPtrFactory<LocalStorageCachedArea> weak_factory_;
DISALLOW_COPY_AND_ASSIGN(LocalStorageCachedArea);
};

Powered by Google App Engine
This is Rietveld 408576698