Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 1837843002: Remove RegExp.prototype.source getter compat workaround (Closed)

Created:
4 years, 8 months ago by Dan Ehrenberg
Modified:
4 years, 8 months ago
Reviewers:
adamk
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove RegExp.prototype.source getter compat workaround The getter RegExp.prototype.source is specified in ES2015 to throw when called on a non-RegExp instance, such as RegExp.prototype. We had previously put in a compatibility workaround for all RegExp getters to make them throw on access specifically with RegExp.prototype as the receiver; however, we only have evidence that this is needed for properties other than source. This patch removes the compatibility workaround for get RegExp.prototype.source and gives it semantics precisely as per the ES2015 specification. R=adamk BUG=chromium:581577, v8:4827 LOG=Y Committed: https://crrev.com/80803aa89e31839b8f73959776fa7e1923c6b461 Cr-Commit-Position: refs/heads/master@{#35086}

Patch Set 1 #

Patch Set 2 : Fix tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -8 lines) Patch
M src/js/regexp.js View 1 chunk +0 lines, -5 lines 0 comments Download
M test/mjsunit/es6/regexp-flags.js View 1 1 chunk +5 lines, -1 line 0 comments Download
M test/test262/test262.status View 1 chunk +0 lines, -1 line 0 comments Download
M test/webkit/fast/regex/toString-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1837843002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1837843002/20001
4 years, 8 months ago (2016-03-28 19:22:27 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-03-28 19:41:59 UTC) #4
Dan Ehrenberg
4 years, 8 months ago (2016-03-28 20:27:31 UTC) #5
adamk
lgtm
4 years, 8 months ago (2016-03-28 20:38:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1837843002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1837843002/20001
4 years, 8 months ago (2016-03-28 20:38:42 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-03-28 20:42:47 UTC) #9
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/80803aa89e31839b8f73959776fa7e1923c6b461 Cr-Commit-Position: refs/heads/master@{#35086}
4 years, 8 months ago (2016-03-28 20:43:09 UTC) #11
Dan Ehrenberg
4 years, 8 months ago (2016-03-31 17:23:53 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1847783003/ by littledan@chromium.org.

The reason for reverting is: TC39 decided that this compatibility fix should be
standardized..

Powered by Google App Engine
This is Rietveld 408576698