Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1837833004: Remove in-process PPB_Graphics3D (Closed)

Created:
4 years, 8 months ago by piman
Modified:
4 years, 8 months ago
Reviewers:
bbudge
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove in-process PPB_Graphics3D It's not used, no need to carry the maintenance burden. BUG=280282 Committed: https://crrev.com/b69b178be71acd1e3fb02d68b52e3e66bb15129a Cr-Commit-Position: refs/heads/master@{#383785}

Patch Set 1 #

Patch Set 2 : fix compile errors #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -64 lines) Patch
M chrome/test/ppapi/ppapi_browsertest.cc View 1 chunk +1 line, -6 lines 0 comments Download
M content/renderer/pepper/ppb_graphics_3d_impl.h View 2 chunks +0 lines, -4 lines 0 comments Download
M content/renderer/pepper/ppb_graphics_3d_impl.cc View 1 5 chunks +0 lines, -53 lines 0 comments Download
M content/renderer/pepper/resource_creation_impl.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
piman
4 years, 8 months ago (2016-03-29 01:54:17 UTC) #2
bbudge
LGTM modulo fixing compile errors
4 years, 8 months ago (2016-03-29 17:43:44 UTC) #3
bbudge
LGTM modulo fixing compile errors
4 years, 8 months ago (2016-03-29 17:43:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1837833004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1837833004/1
4 years, 8 months ago (2016-03-29 17:52:38 UTC) #8
piman
On 2016/03/29 17:43:44, bbudge wrote: > LGTM modulo fixing compile errors Yep, thanks, done!
4 years, 8 months ago (2016-03-29 17:53:11 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-03-29 19:03:00 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-03-29 19:04:01 UTC) #12
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/b69b178be71acd1e3fb02d68b52e3e66bb15129a
Cr-Commit-Position: refs/heads/master@{#383785}

Powered by Google App Engine
This is Rietveld 408576698