third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp - Issue 1837823003: [Binding] Add [OverrideBuiltins] label onto HTMLDocument interface

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp

Issue 1837823003: [Binding] Add [OverrideBuiltins] label onto HTMLDocument interface (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/ScriptController.h ('k') | third_party/WebKit/Source/bindings/core/v8/WindowProxy.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp b/third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp

index d318dd64d4739e303a95011f1114540a275ff7d1..8c8982985ffba3f7d199b491ca2d233541177fb8 100644

--- a/third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp

@@ -288,16 +288,6 @@ void ScriptController::updateDocument()

windowProxy(DOMWrapperWorld::mainWorld())->updateDocument();

}

-void ScriptController::namedItemAdded(HTMLDocument* doc, const AtomicString& name)

- windowProxy(DOMWrapperWorld::mainWorld())->namedItemAdded(doc, name);

-void ScriptController::namedItemRemoved(HTMLDocument* doc, const AtomicString& name)

- windowProxy(DOMWrapperWorld::mainWorld())->namedItemRemoved(doc, name);

static bool isInPrivateScriptIsolateWorld(v8::Isolate* isolate)

{

v8::Local<v8::Context> context = isolate->GetCurrentContext();