Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issue 1837803003: - Limit 32-bit platforms to 1.5GB of memory for old gen by default. (Closed)

Created:
4 years, 8 months ago by Ivan Posva
Modified:
4 years, 8 months ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

- Limit 32-bit platforms to 1.5GB of memory for old gen by default. - Fixed documentation for Dart_NewWeakPersistentHandle. - Add clarifying comment. BUG= R=fschneider@google.com Committed: https://github.com/dart-lang/sdk/commit/528baf2173f033956c23b9b545ee9535df03e62f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -33 lines) Patch
M runtime/include/dart_api.h View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/dart.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M runtime/vm/debugger.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/flag_list.h View 4 chunks +18 lines, -0 lines 0 comments Download
M runtime/vm/isolate.cc View 1 chunk +0 lines, -23 lines 0 comments Download
M runtime/vm/message_handler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/port.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/vm/stub_code_x64.cc View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/thread.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Ivan Posva
4 years, 8 months ago (2016-03-29 00:12:23 UTC) #2
Florian Schneider
lgtm
4 years, 8 months ago (2016-03-29 00:19:16 UTC) #3
Ivan Posva
4 years, 8 months ago (2016-03-29 00:37:58 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
528baf2173f033956c23b9b545ee9535df03e62f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698