Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Issue 1837803002: Revert of Add keyboard accessibility to ConstrainedWindowButton (Closed)

Created:
4 years, 8 months ago by juncai
Modified:
4 years, 8 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews, Reilly Grant (use Gerrit)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add keyboard accessibility to ConstrainedWindowButton (patchset #2 id:20001 of https://codereview.chromium.org/1829393002/ ) Reason for revert: There is a setting on Mac that can control the keyboard access: System Preferences -> Keyboard -> Shortcuts At the bottom, it has: "Full Keyboard Access: In windows and dialogs, press Tab to move keyboard focus between: Text boxes and lists only All controls" When setting to "All controls", without the change in this patch, pressing the tab can navigate the buttons and space works like pressing the button. So this patch is not needed. Original issue's description: > Add keyboard accessibility to ConstrainedWindowButton > > This patch added keyboard accessibility to ConstrainedWindowButton. > > ConstrainedWindowButton is used by WebUSB chooser bubble, > Geolocation permission bubble, etc. Previously, when trying to only > interact with these bubbles with the keyboard, there are no focus > styles. User should be able to press tab to navigate to buttons, and > see a visible focus state. It will allow the user to only use keyboard > to control the bubble, which improves the accessibility of the UI > that uses it. > > BUG=596671 > > Committed: https://crrev.com/9f0ead0fd04825415795733a60d1cf587fd12b2a > Cr-Commit-Position: refs/heads/master@{#383368} TBR=rsesek@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=596671 Committed: https://crrev.com/9011b1f0bf8dbf920a95bc32f9ba7c01f0d6c28f Cr-Commit-Position: refs/heads/master@{#383523}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5 lines) Patch
M chrome/browser/ui/cocoa/constrained_window/constrained_window_button.mm View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/website_settings/chooser_bubble_ui_cocoa.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
juncai
Created Revert of Add keyboard accessibility to ConstrainedWindowButton
4 years, 8 months ago (2016-03-28 17:50:02 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1837803002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1837803002/1
4 years, 8 months ago (2016-03-28 17:50:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1837803002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1837803002/1
4 years, 8 months ago (2016-03-28 18:01:36 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-28 18:22:05 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-03-28 18:24:15 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9011b1f0bf8dbf920a95bc32f9ba7c01f0d6c28f
Cr-Commit-Position: refs/heads/master@{#383523}

Powered by Google App Engine
This is Rietveld 408576698