Chromium Code Reviews
DescriptionRevert of Add keyboard accessibility to ConstrainedWindowButton (patchset #2 id:20001 of https://codereview.chromium.org/1829393002/ )
Reason for revert:
There is a setting on Mac that can control the keyboard access:
System Preferences -> Keyboard -> Shortcuts
At the bottom, it has:
"Full Keyboard Access: In windows and dialogs, press Tab to move keyboard focus
between:
Text boxes and lists only
All controls"
When setting to "All controls", without the change in this
patch, pressing the tab can navigate the buttons and space
works like pressing the button. So this patch is not
needed.
Original issue's description:
> Add keyboard accessibility to ConstrainedWindowButton
>
> This patch added keyboard accessibility to ConstrainedWindowButton.
>
> ConstrainedWindowButton is used by WebUSB chooser bubble,
> Geolocation permission bubble, etc. Previously, when trying to only
> interact with these bubbles with the keyboard, there are no focus
> styles. User should be able to press tab to navigate to buttons, and
> see a visible focus state. It will allow the user to only use keyboard
> to control the bubble, which improves the accessibility of the UI
> that uses it.
>
> BUG=596671
>
> Committed: https://crrev.com/9f0ead0fd04825415795733a60d1cf587fd12b2a
> Cr-Commit-Position: refs/heads/master@{#383368}
TBR=rsesek@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=596671
Committed: https://crrev.com/9011b1f0bf8dbf920a95bc32f9ba7c01f0d6c28f
Cr-Commit-Position: refs/heads/master@{#383523}
Patch Set 1 #
Messages
Total messages: 8 (3 generated)
|
||||||||||||||||||||||||||||