Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 1837783002: Remove SK_IGNORE_MAC_FONT_WEIGHT_FIX. (Closed)

Created:
4 years, 8 months ago by bungeman-skia
Modified:
4 years, 8 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove SK_IGNORE_MAC_FONT_WEIGHT_FIX. This is now a dead define, and the changes have been rebased in both Skia gold and Blink layout tests. BUG=5095 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1837783002 Committed: https://skia.googlesource.com/skia/+/df801aac5f57c64eb7f081288a299fa3c92cee0d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -27 lines) Patch
M src/ports/SkFontHost_mac.cpp View 5 chunks +0 lines, -27 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1837783002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1837783002/1
4 years, 8 months ago (2016-03-28 17:42:21 UTC) #3
bungeman-skia
Remove the dead code.
4 years, 8 months ago (2016-03-28 17:42:45 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-03-28 17:54:31 UTC) #7
mtklein
lgtm
4 years, 8 months ago (2016-03-28 18:23:03 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1837783002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1837783002/1
4 years, 8 months ago (2016-03-28 18:23:08 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-03-28 18:24:07 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/df801aac5f57c64eb7f081288a299fa3c92cee0d

Powered by Google App Engine
This is Rietveld 408576698