Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 183773003: Only add chrome_redirects as a dependency of base.dll in component builds. (Closed)

Created:
6 years, 9 months ago by Cait (Slow)
Modified:
6 years, 9 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org, caitkp+watch_chromium.org
Visibility:
Public.

Description

Only add chrome_redirects as a dependency of base.dll in component builds. This will cover most of the CreateFile calls and save us from death by circular gyp dependencies. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=254231

Patch Set 1 #

Patch Set 2 : Hardcode depth #

Patch Set 3 : #

Patch Set 4 : try again #

Patch Set 5 : remove last redirects ref #

Patch Set 6 : no deps change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -61 lines) Patch
M base/base.gyp View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M build/common.gypi View 1 2 3 4 1 chunk +0 lines, -7 lines 0 comments Download
M chrome_elf/chrome_elf.gyp View 1 2 3 4 6 chunks +0 lines, -54 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Cait (Slow)
robertshield: PTAL at chrome_elf.gyp changes. mark: PTAL at base.gyp changes. For context: the purpose of ...
6 years, 9 months ago (2014-02-27 22:27:06 UTC) #1
robertshield
LGTM
6 years, 9 months ago (2014-02-27 22:50:26 UTC) #2
Mark Mentovai
LGTM
6 years, 9 months ago (2014-02-27 22:51:58 UTC) #3
Cait (Slow)
The CQ bit was checked by caitkp@chromium.org
6 years, 9 months ago (2014-02-28 19:33:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/caitkp@chromium.org/183773003/80001
6 years, 9 months ago (2014-02-28 19:34:49 UTC) #5
commit-bot: I haz the power
6 years, 9 months ago (2014-02-28 21:15:21 UTC) #6
Message was sent while issue was closed.
Change committed as 254231

Powered by Google App Engine
This is Rietveld 408576698