Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1837673003:
Obsolete old PLT.* histograms in favor of PageLoad.* histograms. (Closed)
|
Created:
4 years, 9 months ago by Bryan McQuade Modified:
4 years, 4 months ago Reviewers:
Ilya Sherman CC:
asvitkine+watch_chromium.org, chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionObsolete old PLT.* histograms in favor of PageLoad.* histograms.
In a subsequent change in a few months time, we'll remove
page_load_histograms.cc, which is responsible for logging these
histograms. We want to give a few months time where the histograms
are still logged, in case there are still users of these histograms
that we're not currently aware of.
See
https://groups.google.com/a/google.com/d/topic/chrome-metrics-team/icBD6tSvMyo/discussion
for more context.
BUG=595742
Committed: https://crrev.com/7410e070f179e1e36bdb358c188c63c4a148de3c
Cr-Commit-Position: refs/heads/master@{#409272}
Patch Set 1 #Patch Set 2 : update names #Patch Set 3 : more deprecations #Patch Set 4 : fix ordering #Patch Set 5 : revert a few mistaken changes #Patch Set 6 : fix a few obsolete messages #Messages
Total messages: 23 (18 generated)
The CQ bit was checked by bmcquade@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by bmcquade@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by bmcquade@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by bmcquade@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Obsolete old PLT.* histograms in favor of PageLoad.* histograms. BUG=595742 ========== to ========== Obsolete old PLT.* histograms in favor of PageLoad.* histograms. In a subsequent change in a few months time, we'll remove page_load_histograms.cc, which is responsible for logging these histograms. We want to give a few months time where the histograms are still logged, in case there are still users of these histograms that we're not currently aware of. BUG=595742 ==========
The CQ bit was checked by bmcquade@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Obsolete old PLT.* histograms in favor of PageLoad.* histograms. In a subsequent change in a few months time, we'll remove page_load_histograms.cc, which is responsible for logging these histograms. We want to give a few months time where the histograms are still logged, in case there are still users of these histograms that we're not currently aware of. BUG=595742 ========== to ========== Obsolete old PLT.* histograms in favor of PageLoad.* histograms. In a subsequent change in a few months time, we'll remove page_load_histograms.cc, which is responsible for logging these histograms. We want to give a few months time where the histograms are still logged, in case there are still users of these histograms that we're not currently aware of. See https://groups.google.com/a/google.com/d/topic/chrome-metrics-team/icBD6tSvMy... for more context. BUG=595742 ==========
bmcquade@chromium.org changed reviewers: + isherman@chromium.org
Description was changed from ========== Obsolete old PLT.* histograms in favor of PageLoad.* histograms. In a subsequent change in a few months time, we'll remove page_load_histograms.cc, which is responsible for logging these histograms. We want to give a few months time where the histograms are still logged, in case there are still users of these histograms that we're not currently aware of. See https://groups.google.com/a/google.com/d/topic/chrome-metrics-team/icBD6tSvMy... for more context. BUG=595742 ========== to ========== Obsolete old PLT.* histograms in favor of PageLoad.* histograms. In a subsequent change in a few months time, we'll remove page_load_histograms.cc, which is responsible for logging these histograms. We want to give a few months time where the histograms are still logged, in case there are still users of these histograms that we're not currently aware of. See https://groups.google.com/a/google.com/d/topic/chrome-metrics-team/icBD6tSvMy... for more context. BUG=595742 ==========
PTAL
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
LGTM, thanks!
The CQ bit was checked by bmcquade@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #6 (id:100001)
Message was sent while issue was closed.
Description was changed from ========== Obsolete old PLT.* histograms in favor of PageLoad.* histograms. In a subsequent change in a few months time, we'll remove page_load_histograms.cc, which is responsible for logging these histograms. We want to give a few months time where the histograms are still logged, in case there are still users of these histograms that we're not currently aware of. See https://groups.google.com/a/google.com/d/topic/chrome-metrics-team/icBD6tSvMy... for more context. BUG=595742 ========== to ========== Obsolete old PLT.* histograms in favor of PageLoad.* histograms. In a subsequent change in a few months time, we'll remove page_load_histograms.cc, which is responsible for logging these histograms. We want to give a few months time where the histograms are still logged, in case there are still users of these histograms that we're not currently aware of. See https://groups.google.com/a/google.com/d/topic/chrome-metrics-team/icBD6tSvMy... for more context. BUG=595742 Committed: https://crrev.com/7410e070f179e1e36bdb358c188c63c4a148de3c Cr-Commit-Position: refs/heads/master@{#409272} ==========
Message was sent while issue was closed.
Patchset 6 (id:??) landed as https://crrev.com/7410e070f179e1e36bdb358c188c63c4a148de3c Cr-Commit-Position: refs/heads/master@{#409272} |
