Chromium Code Reviews Chromium Code Reviews
Issue 1837663002:
Initial Subzero WASM prototype. (Closed)
Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master| Index: Makefile.standalone |
| diff --git a/Makefile.standalone b/Makefile.standalone |
| index 716e8d6fbdd0610832f66ff7c6d6f5cd199cdf1b..9f3c793840dbd7acf331d1115679a292fd8dffad 100644 |
| --- a/Makefile.standalone |
| +++ b/Makefile.standalone |
| @@ -179,6 +179,9 @@ endif |
| SB_OBJDIR := $(OBJDIR)+Sandboxed |
| SBB_OBJDIR := $(OBJDIR)+SandboxedBrowser |
| +V8_DIR = ../../../../v8 |
| +V8_CXXFLAGS := -I$(V8_DIR) |
| + |
| $(info -----------------------------------------------) |
| $(info Using LLVM_SRC_PATH = $(LLVM_SRC_PATH)) |
| $(info Using SB_LLVM_PATH = $(SB_LLVM_PATH)) |
| @@ -251,15 +254,25 @@ ifdef GPLUSPLUS |
| OBJDIR := $(OBJDIR)+Gplusplus |
| endif |
| -BASE_CXXFLAGS := -std=gnu++11 -Wall -Wextra -Werror -fno-rtti \ |
| +BASE_CXXFLAGS := -std=gnu++11 -Wall -Wextra -fno-rtti \ |
| -fno-exceptions $(OPTLEVEL) $(ASSERTIONS) -g -pedantic \ |
| $(LLVM_EXTRA_WARNINGS) $(CXX_EXTRA) -MP -MD |
| +ifndef WASM |
| + # The WASM code inherits a lot of V8 code, which does not compile with |
| + # -Werror. |
| + BASE_CXXFLAGS += -Werror |
| +endif |
| + |
| CXXFLAGS := $(LLVM_CXXFLAGS) $(BASE_CXXFLAGS) $(CXX_DEFINES) $(HOST_FLAGS) \ |
| $(STDLIB_FLAGS) |
| SB_CXXFLAGS := $(SB_LLVM_CXXFLAGS) $(BASE_CXXFLAGS) $(BASE_CXX_DEFINES) \ |
| -Wno-unknown-pragmas -I$(NACL_ROOT) -I$(NACL_ROOT)/.. |
| +ifdef WASM |
| + CXXFLAGS += $(V8_CXXFLAGS) -DSUBZERO_WASM |
|
Jim Stichnoth
2016/03/29 17:49:56
Follow the pattern above where you also modify OBJ
Eric Holk
2016/03/29 22:58:07
Done, assuming I understood the comment correctly.
|
| +endif |
| + |
| LDFLAGS := $(HOST_FLAGS) -L$(LIBCXX_INSTALL_PATH)/lib -Wl,--gc-sections \ |
| $(LD_EXTRA) $(STDLIB_FLAGS) |
| # Not specifying -Wl,--gc-sections but instead doing bitcode linking GC w/ LTO. |
| @@ -315,6 +328,11 @@ ifndef MINIMAL |
| IceTypeConverter.cpp |
| endif |
| +ifdef WASM |
| + SRCS += \ |
| + WasmTranslator.cpp |
| +endif |
| + |
| OBJS=$(patsubst %.cpp, $(OBJDIR)/%.o, $(SRCS)) |
| SB_OBJS=$(patsubst %.cpp, $(SB_OBJDIR)/%.o, $(SRCS)) |
| SBB_OBJS=$(patsubst %.cpp, $(SBB_OBJDIR)/%.o, $(SRCS)) |
| @@ -392,9 +410,19 @@ sb_make_symlink: $(NEXES) |
| compile_only: $(OBJS) |
| +V8_LIBDIR=$(V8_DIR)/out/native/lib.target |
| + |
| +ifdef WASM |
| + V8_LIBS := \ |
| + $(V8_LIBDIR)/libv8.so \ |
| + $(V8_LIBDIR)/libicuuc.so \ |
| + $(V8_LIBDIR)/libicui18n.so |
| +endif |
| + |
| $(OBJDIR)/pnacl-sz: $(OBJS) |
| $(CXX) $(LDFLAGS) -o $@ $^ $(LLVM_LDFLAGS) \ |
| - -Wl,-rpath=$(abspath $(LIBCXX_INSTALL_PATH)/lib) |
| + -Wl,-rpath=$(abspath $(LIBCXX_INSTALL_PATH)/lib) \ |
| + $(V8_LIBS) |
|
Jim Stichnoth
2016/03/29 17:49:56
untabify this line (or just add it to the previous
Eric Holk
2016/03/29 22:58:07
Done.
|
| $(SB_OBJDIR)/pnacl-sz.nonfinal.pexe: $(SB_OBJS) |
| $(SB_CXX) $(SB_LDFLAGS) -o $@ $^ $(SB_LLVM_LDFLAGS) |
