Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1825)

Unified Diff: base/memory/discardable_memory_allocator_android_unittest.cc

Issue 183763037: Update AshmemRegion::highest_allocated_chunk_ when merging free chunks. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove unnecessary allocator instance in unit test Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/memory/discardable_memory_allocator_android.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/memory/discardable_memory_allocator_android_unittest.cc
diff --git a/base/memory/discardable_memory_allocator_android_unittest.cc b/base/memory/discardable_memory_allocator_android_unittest.cc
index 3f756047ae8ae7c7534d254ddc5e8a0bf2cd438b..b2e8d558608fb03c6f5a5142e63f1d30ef30009b 100644
--- a/base/memory/discardable_memory_allocator_android_unittest.cc
+++ b/base/memory/discardable_memory_allocator_android_unittest.cc
@@ -271,8 +271,6 @@ TEST_F(DiscardableMemoryAllocatorTest, UseMultipleAshmemRegions) {
TEST_F(DiscardableMemoryAllocatorTest,
HighestAllocatedChunkPointerIsUpdatedWhenHighestChunkGetsSplit) {
- DiscardableMemoryAllocator allocator_(kAllocatorName, 32 * kPageSize);
Philippe 2014/03/05 15:36:03 FYI, I just uploaded a patch set removing this (wh
-
// Prevents the ashmem region from getting closed when |memory2| gets freed.
scoped_ptr<DiscardableMemory> memory1(allocator_.Allocate(kPageSize));
ASSERT_TRUE(memory1);
« no previous file with comments | « base/memory/discardable_memory_allocator_android.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698