Issue 183763036: TimelineFlameChart: selectRecord implementation

Issue 183763036: TimelineFlameChart: selectRecord implementation (Closed)

Created:
6 years, 9 months ago by loislo

Modified:
6 years, 9 months ago

Reviewers:
alph, pfeldman

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

TimelineFlameChart: selectRecord implementation. BUG=349392 R=pfeldman@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168484

Patch Set 1 #

Patch Set 2 : done #

Total comments: 6

Patch Set 3 : comments addressed #

Patch Set 4 : comments addressed #

Patch Set 5 : rebaselined #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+147 lines, -66 lines)			Patch
M	Source/devtools/front_end/CPUProfileView.js	View	1 2 3 4	3 chunks	+15 lines, -10 lines	0 comments	Download
M	Source/devtools/front_end/FlameChart.js	View	1 2 3 4	16 chunks	+49 lines, -37 lines	0 comments	Download
M	Source/devtools/front_end/TimelineFlameChart.js	View	1 2 3 4	10 chunks	+60 lines, -14 lines	0 comments	Download
M	Source/devtools/front_end/TimelinePanel.js	View	1 2 3 4	3 chunks	+5 lines, -0 lines	0 comments	Download
M	Source/devtools/front_end/flameChart.css	View	1 2 3 4	2 chunks	+14 lines, -1 line	0 comments	Download
M	Source/devtools/front_end/timelinePanel.css	View	1 2 3 4	2 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

pfeldman

https://codereview.chromium.org/183763036/diff/20001/Source/devtools/front_end/TimelineFlameChart.js File Source/devtools/front_end/TimelineFlameChart.js (right): https://codereview.chromium.org/183763036/diff/20001/Source/devtools/front_end/TimelineFlameChart.js#newcode268 Source/devtools/front_end/TimelineFlameChart.js:268: return this._entryRecords[entryIndex]; You should express selection in terms of ...

6 years, 9 months ago (2014-03-05 12:13:02 UTC) #2

alph

https://codereview.chromium.org/183763036/diff/20001/Source/devtools/front_end/timelinePanel.css File Source/devtools/front_end/timelinePanel.css (right): https://codereview.chromium.org/183763036/diff/20001/Source/devtools/front_end/timelinePanel.css#newcode812 Source/devtools/front_end/timelinePanel.css:812: border-color: red; May I take a look at a ...

6 years, 9 months ago (2014-03-05 12:41:10 UTC) #3

pfeldman

> May I take a look at a screenshot? Might that happen the entry has ...

6 years, 9 months ago (2014-03-05 12:56:35 UTC) #4

loislo

comments addressed https://codereview.chromium.org/183763036/diff/20001/Source/devtools/front_end/TimelineFlameChart.js File Source/devtools/front_end/TimelineFlameChart.js (right): https://codereview.chromium.org/183763036/diff/20001/Source/devtools/front_end/TimelineFlameChart.js#newcode284 Source/devtools/front_end/TimelineFlameChart.js:284: highlightTimeRange: function(entryIndex) On 2014/03/05 12:13:02, pfeldman wrote: ...

6 years, 9 months ago (2014-03-05 12:57:54 UTC) #5

loislo

Committed patchset #5 manually as r168484 (presubmit successful).

6 years, 9 months ago (2014-03-05 15:19:48 UTC) #7

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages