Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 183763033: Avoid calling hasAttribute() and then getAttribute() for performance (Closed)

Created:
6 years, 9 months ago by Inactive
Modified:
6 years, 9 months ago
Reviewers:
eseidel, rwlbuis
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, dglazkov+blink, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, adamk+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

Avoid calling hasAttribute() and then getAttribute() for performance Avoid calling hasAttribute() and then getAttribute() for performance. This causes the attribute to be looked up (linear search) twice instead of once if we call getAttribute() directly and then check if the returned AtomicString is null. R=eseidel@chromium.org, eseidel, rwlbuis Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168423

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -10 lines) Patch
M Source/core/editing/EditingStyle.cpp View 2 chunks +6 lines, -4 lines 0 comments Download
M Source/core/editing/SplitElementCommand.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M Source/core/html/HTMLAnchorElement.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M Source/core/inspector/DOMEditor.cpp View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Inactive
6 years, 9 months ago (2014-03-04 22:06:51 UTC) #1
eseidel
lgtm I doubt this matters much, but lgtm.
6 years, 9 months ago (2014-03-04 22:25:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/183763033/1
6 years, 9 months ago (2014-03-04 22:26:57 UTC) #3
Inactive
6 years, 9 months ago (2014-03-05 03:13:28 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r168423 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698