Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 183763029: DevTools: move InspectorStyleSheet::ensureSourceData to ParsedStyleSheet (Closed)

Created:
6 years, 9 months ago by lushnikov
Modified:
6 years, 9 months ago
Reviewers:
apavlov, vsevik
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

DevTools: move InspectorStyleSheet::ensureSourceData to ParsedStyleSheet This patch moves InspectorStyleSheet::ensureSourceData to ParsedStyleSheet. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168469

Patch Set 1 : move createCSSParser to outer space #

Patch Set 2 : move StyleSheetHandler anonymous namespace out of webcore #

Patch Set 3 : refactoring: move ensureSourceData to ParsedStyleSheet #

Patch Set 4 : Drive-by: remove unused typedef InspectorStyleMap #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -96 lines) Patch
M Source/core/inspector/InspectorStyleSheet.h View 1 2 3 2 chunks +0 lines, -2 lines 0 comments Download
M Source/core/inspector/InspectorStyleSheet.cpp View 1 2 5 chunks +100 lines, -94 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
lushnikov
6 years, 9 months ago (2014-03-04 09:34:45 UTC) #1
apavlov
lgtm once trybots are green
6 years, 9 months ago (2014-03-04 10:18:50 UTC) #2
lushnikov
The CQ bit was checked by lushnikov@chromium.org
6 years, 9 months ago (2014-03-04 11:25:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lushnikov@chromium.org/183763029/60001
6 years, 9 months ago (2014-03-04 11:26:24 UTC) #4
lushnikov
The CQ bit was unchecked by lushnikov@chromium.org
6 years, 9 months ago (2014-03-04 14:32:50 UTC) #5
lushnikov
The CQ bit was checked by lushnikov@chromium.org
6 years, 9 months ago (2014-03-04 14:32:51 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-05 08:52:09 UTC) #7
commit-bot: I haz the power
Retried try job too often on linux_blink for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink&number=15352
6 years, 9 months ago (2014-03-05 08:52:11 UTC) #8
lushnikov
The CQ bit was checked by lushnikov@chromium.org
6 years, 9 months ago (2014-03-05 11:51:36 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lushnikov@chromium.org/183763029/60001
6 years, 9 months ago (2014-03-05 11:51:44 UTC) #10
commit-bot: I haz the power
6 years, 9 months ago (2014-03-05 11:52:08 UTC) #11
Message was sent while issue was closed. 
Change committed as 168469

Powered by Google App Engine
This is Rietveld 408576698