Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 183763011: Reland "Add base::TimeDelta::Max()" (Closed)

Created:
6 years, 9 months ago by gavinp
Modified:
6 years, 9 months ago
CC:
chromium-reviews, tim+watch_chromium.org, cbentzel+watch_chromium.org, fischman+watch_chromium.org, haitaol+watch_chromium.org, jam, mcasas+watch_chromium.org, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, cc-bugs_chromium.org, erikwright+watch_chromium.org, wjia+watch_chromium.org, maniscalco+watch_chromium.org
Visibility:
Public.

Description

Reland "Add base::TimeDelta::Max()" Media was exposing max timedeltas to JSON, which wasn't working with infinity. R=scherkus@chromium.org TBR=ajwong@chromium.org,jar@chromium.org,jamesr@chomium.org,acolwell@chromium.org,nick@chromium.org BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=254717

Patch Set 1 #

Patch Set 2 : print unknown #

Patch Set 3 : print "unknown" #

Patch Set 4 : print "unknown" #

Patch Set 5 : print "unknown" #

Patch Set 6 : print "unknown" #

Unified diffs Side-by-side diffs Delta from patch set Stats (+131 lines, -24 lines) Patch
M base/time/time.h View 4 chunks +34 lines, -6 lines 0 comments Download
M base/time/time.cc View 1 chunk +41 lines, -0 lines 0 comments Download
M base/time/time_unittest.cc View 1 chunk +40 lines, -0 lines 0 comments Download
M cc/debug/rasterize_and_record_benchmark.cc View 1 chunk +1 line, -2 lines 0 comments Download
M cc/debug/rasterize_and_record_benchmark_impl.cc View 1 chunk +1 line, -2 lines 0 comments Download
M cc/resources/picture_pile.cc View 1 chunk +1 line, -2 lines 0 comments Download
M cc/resources/picture_pile_impl.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/renderer/media/websourcebuffer_impl.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M media/base/buffers.h View 1 chunk +1 line, -1 line 0 comments Download
M media/base/media_log.cc View 1 1 chunk +4 lines, -1 line 0 comments Download
M media/filters/chunk_demuxer.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/http/http_response_headers.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/spdy_session.cc View 1 chunk +1 line, -3 lines 0 comments Download
M sync/sessions/nudge_tracker.cc View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
gavinp
scherkus: PTAL, I call the time period "unknown" as we discussed in email.
6 years, 9 months ago (2014-03-03 19:14:10 UTC) #1
scherkus (not reviewing)
media lgtm appreciate the fix!
6 years, 9 months ago (2014-03-04 01:50:06 UTC) #2
awong
rubber-stamp LGTM
6 years, 9 months ago (2014-03-04 01:50:53 UTC) #3
gavinp
The CQ bit was checked by gavinp@chromium.org
6 years, 9 months ago (2014-03-04 02:10:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gavinp@chromium.org/183763011/100001
6 years, 9 months ago (2014-03-04 02:14:59 UTC) #5
commit-bot: I haz the power
Change committed as 254717
6 years, 9 months ago (2014-03-04 08:15:01 UTC) #6
apavlov
A revert of this CL has been created in https://codereview.chromium.org/179813009/ by apavlov@chromium.org. The reason for ...
6 years, 9 months ago (2014-03-04 10:57:29 UTC) #7
gavinp
6 years, 9 months ago (2014-03-04 14:42:38 UTC) #8
Message was sent while issue was closed.
On 2014/03/04 10:57:29, apavlov wrote:
> A revert of this CL has been created in
> https://codereview.chromium.org/179813009/ by mailto:apavlov@chromium.org.
> 
> The reason for reverting is: http/tests/media/video-cookie.html is asserting
on
> debug bots.

Scary how much the media log was doing this. See
https://codereview.chromium.org/186683002/ for the fix.

Powered by Google App Engine
This is Rietveld 408576698