Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Issue 1837583002: Remove unneeded using Base::capacity in WTF::Vector definition. (Closed)

Created:
4 years, 9 months ago by dcheng
Modified:
4 years, 9 months ago
Reviewers:
haraken
CC:
blink-reviews, blink-reviews-wtf_chromium.org, chromium-reviews, danakj, Mikhail, Nico
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unneeded using Base::capacity in WTF::Vector definition. Redundant since Vector already defines capacity() as a public method, and it confuses the Chrome style rewriter. From C++11 [namespace.udecl/15]: When a using-declaration brings names from a base class into a derived class scope, member functions and member function templates in the derived class override and/or hide member functions and member function templates with the same name, parameter-type-list (8.3.5), cv-qualification, and ref-qualifier (if any) in a base class (rather than conflicting). BUG=584105 Committed: https://crrev.com/2edf9869450cdd9337eab5bc92623a0f074cc7ed Cr-Commit-Position: refs/heads/master@{#383415}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M third_party/WebKit/Source/wtf/Vector.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
dcheng
By the way, any chance of getting another PST owner for Source/wtf? thakis is OOO ...
4 years, 9 months ago (2016-03-25 21:18:13 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1837583002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1837583002/1
4 years, 9 months ago (2016-03-25 21:18:56 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-25 22:48:41 UTC) #7
haraken
LGTM
4 years, 9 months ago (2016-03-25 23:57:07 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1837583002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1837583002/1
4 years, 9 months ago (2016-03-26 00:00:08 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-26 00:05:50 UTC) #11
commit-bot: I haz the power
4 years, 9 months ago (2016-03-26 00:07:56 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2edf9869450cdd9337eab5bc92623a0f074cc7ed
Cr-Commit-Position: refs/heads/master@{#383415}

Powered by Google App Engine
This is Rietveld 408576698