Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: src/pdf/SkPDFDevice.h

Issue 1837553002: SkPDF s/SkAutoTDelete/std::unique_ptr/ (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/pdf/SkPDFDevice.h
diff --git a/src/pdf/SkPDFDevice.h b/src/pdf/SkPDFDevice.h
index 095bbe96379a1d21adf9b34859c85795174dcdb4..c3543df6cdcc6cd6ce8cf55cfc5265ee5f36d85b 100644
--- a/src/pdf/SkPDFDevice.h
+++ b/src/pdf/SkPDFDevice.h
@@ -248,19 +248,19 @@ private:
SkTDArray<SkPDFFont*> fFontResources;
SkTDArray<SkPDFObject*> fShaderResources;
- SkAutoTDelete<ContentEntry> fContentEntries;
+ std::unique_ptr<ContentEntry> fContentEntries;
ContentEntry* fLastContentEntry;
- SkAutoTDelete<ContentEntry> fMarginContentEntries;
+ std::unique_ptr<ContentEntry> fMarginContentEntries;
ContentEntry* fLastMarginContentEntry;
DrawingArea fDrawingArea;
const SkClipStack* fClipStack;
// Accessor and setter functions based on the current DrawingArea.
- SkAutoTDelete<ContentEntry>* getContentEntries();
+ std::unique_ptr<ContentEntry>* getContentEntries();
bungeman-skia 2016/03/25 19:54:22 Not really for this CL, but shouldn't this return
hal.canary 2016/03/28 14:23:32 I removed this function altogether in crrev.com/18
// Glyph ids used for each font on this device.
- SkAutoTDelete<SkPDFGlyphSetMap> fFontGlyphUsage;
+ std::unique_ptr<SkPDFGlyphSetMap> fFontGlyphUsage;
SkScalar fRasterDpi;
« no previous file with comments | « src/pdf/SkPDFBitmap.cpp ('k') | src/pdf/SkPDFDevice.cpp » ('j') | src/pdf/SkPDFDevice.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698