SkPDF s/SkAutoTDelete/std::unique_ptr/

SkPDF s/SkAutoTDelete/std::unique_ptr/

GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1837553002

Committed: https://skia.googlesource.com/skia/+/b8fb9934a0707e8e5f9e725502974dc2d432a815

[hal.canary, 2016-03-25 19:20:58]

Description was changed from

==========
SkPDF s/SkAutoTDelete/std::unique_ptr/
==========

to

==========
SkPDF s/SkAutoTDelete/std::unique_ptr/
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[hal.canary, 2016-03-25 19:21:38]

The CQ bit was checked by halcanary@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-03-25 19:21:40]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1837553002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1837553002/1

[hal.canary, 2016-03-25 19:21:45]

Description was changed from

==========
SkPDF s/SkAutoTDelete/std::unique_ptr/
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
SkPDF s/SkAutoTDelete/std::unique_ptr/

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[commit-bot: I haz the power, 2016-03-25 19:33:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-25 19:34:00]

Dry run: This issue passed the CQ dry run.

[hal.canary, 2016-03-25 19:34:34]

halcanary@google.com changed reviewers:
+ bungeman@google.com

[hal.canary, 2016-03-25 19:34:35]

this is a sed-only CL.

[bungeman-skia, 2016-03-25 19:54:22]

https://codereview.chromium.org/1837553002/diff/1/src/pdf/SkPDFDevice.cpp
File src/pdf/SkPDFDevice.cpp (right):

https://codereview.chromium.org/1837553002/diff/1/src/pdf/SkPDFDevice.cpp#new...
src/pdf/SkPDFDevice.cpp:595: std::unique_ptr<ContentEntry> fNext;
Hopefully this doesn't break the Android NDK build (unique_ptr to incomplete
type), but it probably will. If you do submit this, you'll need to keep an eye
on it. See SkHackyAutoTDelete for the current workaround elsewhere.

https://codereview.chromium.org/1837553002/diff/1/src/pdf/SkPDFDevice.h
File src/pdf/SkPDFDevice.h (right):

https://codereview.chromium.org/1837553002/diff/1/src/pdf/SkPDFDevice.h#newco...
src/pdf/SkPDFDevice.h:260: std::unique_ptr<ContentEntry>* getContentEntries();
Not really for this CL, but shouldn't this return either a 'const
std::unique_ptr<ContentEntry>&' or just a 'const ContentEntry&' (or non-const,
as the case may be).

https://codereview.chromium.org/1837553002/diff/1/src/pdf/SkPDFShader.h
File src/pdf/SkPDFShader.h (right):

https://codereview.chromium.org/1837553002/diff/1/src/pdf/SkPDFShader.h#newco...
src/pdf/SkPDFShader.h:59: std::unique_ptr<SkPDFShader::State>*);
Not really about this CL, but these all passing pointers to unique_ptr seems
awkward.

[hal.canary, 2016-03-28 14:23:33]

https://codereview.chromium.org/1837553002/diff/1/src/pdf/SkPDFDevice.cpp
File src/pdf/SkPDFDevice.cpp (right):

https://codereview.chromium.org/1837553002/diff/1/src/pdf/SkPDFDevice.cpp#new...
src/pdf/SkPDFDevice.cpp:595: std::unique_ptr<ContentEntry> fNext;
On 2016/03/25 19:54:22, bungeman1 wrote:
> Hopefully this doesn't break the Android NDK build (unique_ptr to incomplete
> type), but it probably will. If you do submit this, you'll need to keep an eye
> on it. See SkHackyAutoTDelete for the current workaround elsewhere.

I'll hold off on these.  This should be a linked list;  I'll clean this up and
make it more readable in another CL.

https://codereview.chromium.org/1837553002/diff/1/src/pdf/SkPDFDevice.h
File src/pdf/SkPDFDevice.h (right):

https://codereview.chromium.org/1837553002/diff/1/src/pdf/SkPDFDevice.h#newco...
src/pdf/SkPDFDevice.h:260: std::unique_ptr<ContentEntry>* getContentEntries();
On 2016/03/25 19:54:22, bungeman1 wrote:
> Not really for this CL, but shouldn't this return either a 'const
> std::unique_ptr<ContentEntry>&' or just a 'const ContentEntry&' (or non-const,
> as the case may be).

I removed this function altogether in crrev.com/1837453003

https://codereview.chromium.org/1837553002/diff/1/src/pdf/SkPDFShader.h
File src/pdf/SkPDFShader.h (right):

https://codereview.chromium.org/1837553002/diff/1/src/pdf/SkPDFShader.h#newco...
src/pdf/SkPDFShader.h:59: std::unique_ptr<SkPDFShader::State>*);
On 2016/03/25 19:54:22, bungeman1 wrote:
> Not really about this CL, but these all passing pointers to unique_ptr seems
> awkward.

Acknowledged.

But it is clear about ownership.

[bungeman-skia, 2016-03-28 14:47:46]

lgtm

https://codereview.chromium.org/1837553002/diff/1/src/pdf/SkPDFShader.h
File src/pdf/SkPDFShader.h (right):

https://codereview.chromium.org/1837553002/diff/1/src/pdf/SkPDFShader.h#newco...
src/pdf/SkPDFShader.h:59: std::unique_ptr<SkPDFShader::State>*);
On 2016/03/28 14:23:32, Hal Canary wrote:
> On 2016/03/25 19:54:22, bungeman1 wrote:
> > Not really about this CL, but these all passing pointers to unique_ptr seems
> > awkward.
> 
> Acknowledged.
> 
> But it is clear about ownership.

Looks like you might be able to take unique_ptr by value now that these are
movable. But that can wait for another CL.

[bungeman-skia, 2016-03-28 14:47:53]

The CQ bit was checked by bungeman@google.com

[commit-bot: I haz the power, 2016-03-28 14:47:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1837553002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1837553002/20001

[commit-bot: I haz the power, 2016-03-28 14:58:32]

Description was changed from

==========
SkPDF s/SkAutoTDelete/std::unique_ptr/

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
SkPDF s/SkAutoTDelete/std::unique_ptr/

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/b8fb9934a0707e8e5f9e725502974dc2d432a815
==========

[commit-bot: I haz the power, 2016-03-28 14:58:33]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/b8fb9934a0707e8e5f9e725502974dc2d432a815