fpdfsdk/javascript/util.h - Issue 1837543002: Added test for util.printx() and make it match spec.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/javascript/util.h

Issue 1837543002: Added test for util.printx() and make it match spec. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Cross-contamination with other CL Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/javascript/util.h

diff --git a/fpdfsdk/javascript/util.h b/fpdfsdk/javascript/util.h

index 17f252d6dc16fbadaa88b17cdaf4c15db9b475ce..97b636272b050cee6d6e971c5e7878be9036766f 100644

--- a/fpdfsdk/javascript/util.h

+++ b/fpdfsdk/javascript/util.h

@@ -38,9 +38,8 @@ class util : public CJS_EmbedObj {

CJS_Value& vRet,

CFX_WideString& sError);

- static void printx(const std::string& cFormat,

- const std::string& cSource,

- std::string& cPurpose);

+ static std::string printx(const std::string& cFormat,

dsinclair 2016/03/28 18:39:01 std::string and not one of the CFX_ByteString vari

Tom Sepez 2016/03/28 19:03:41 Yes, because we're going to pass it around to vari

+ const std::string& cSource);

};

class CJS_Util : public CJS_Object {