Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1307)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutObject.h

Issue 1837533002: LayoutObject::localOverflowRectForPaintInvalidation() and localSelectionRect() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@pi0
Patch Set: Rebase Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutObject.h
diff --git a/third_party/WebKit/Source/core/layout/LayoutObject.h b/third_party/WebKit/Source/core/layout/LayoutObject.h
index 032c868d381d8afc027e99177649b90c23547033..47360a2a1143961d12b6fc4684799eb0c14b59ae 100644
--- a/third_party/WebKit/Source/core/layout/LayoutObject.h
+++ b/third_party/WebKit/Source/core/layout/LayoutObject.h
@@ -1103,11 +1103,6 @@ public:
bool isPaintInvalidationContainer() const;
- LayoutRect computePaintInvalidationRect()
- {
- return computePaintInvalidationRect(containerForPaintInvalidation());
- }
-
// Returns the paint invalidation rect for this LayoutObject in the coordinate space of the paint backing (typically a GraphicsLayer) for |paintInvalidationContainer|.
LayoutRect computePaintInvalidationRect(const LayoutBoxModelObject& paintInvalidationContainer, const PaintInvalidationState* = nullptr) const;
@@ -1142,6 +1137,10 @@ public:
virtual LayoutRect absoluteClippedOverflowRect() const;
virtual LayoutRect clippedOverflowRectForPaintInvalidation(const LayoutBoxModelObject* paintInvalidationContainer, const PaintInvalidationState* = nullptr) const;
+ // Returns the rect that should have paint invalidated whenever this object changes. The rect is in the object's
+ // local coordinate space.
+ virtual LayoutRect localOverflowRectForPaintInvalidation() const;
+
// Given a rect in the object's coordinate space, compute a rect in the coordinate space of |ancestor|. If
// intermediate containers have clipping or scrolling of any kind, it is applied; but overflow clipping is
// *not* applied for |ancestor| itself. The output rect is suitable for purposes such as paint invalidation.
@@ -1174,8 +1173,8 @@ public:
bool canUpdateSelectionOnRootLineBoxes() const;
// A single rectangle that encompasses all of the selected objects within this object. Used to determine the tightest
- // possible bounding box for the selection. The rect returned is in the coordinate space of the paint invalidation container's backing.
- virtual LayoutRect selectionRectForPaintInvalidation(const LayoutBoxModelObject* /* paintInvalidationContainer */) const { return LayoutRect(); }
+ // possible bounding box for the selection. The rect returned is in the object's local coordinate space.
+ virtual LayoutRect localSelectionRect() const { return LayoutRect(); }
// View coordinates means the coordinate space of |view()|.
LayoutRect selectionRectInViewCoordinates() const;

Powered by Google App Engine
This is Rietveld 408576698