Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 183753003: Add required header for RangeConstraint definition. (Closed)

Created:
6 years, 9 months ago by eroman
Modified:
6 years, 9 months ago
Reviewers:
jschuh
CC:
chromium-reviews, erikwright+watch_chromium.org
Visibility:
Public.

Description

Add required header for RangeConstraint definition. BUG=332611 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=254005

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M base/numerics/safe_math_impl.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
eroman
Tried using it today but got an error about RangeConstraint. I believe the unit-tests are ...
6 years, 9 months ago (2014-02-27 21:29:23 UTC) #1
jschuh
D'oh! Embarrassed lgtm.
6 years, 9 months ago (2014-02-27 21:40:20 UTC) #2
eroman
The CQ bit was checked by eroman@chromium.org
6 years, 9 months ago (2014-02-27 21:45:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/183753003/1
6 years, 9 months ago (2014-02-27 21:46:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/183753003/1
6 years, 9 months ago (2014-02-28 01:05:28 UTC) #5
commit-bot: I haz the power
6 years, 9 months ago (2014-02-28 01:41:13 UTC) #6
Message was sent while issue was closed.
Change committed as 254005

Powered by Google App Engine
This is Rietveld 408576698