Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1479)

Unified Diff: src/hydrogen-uint32-analysis.cc

Issue 18375004: Fix invalid condition introduced with revision 15441. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/hydrogen-uint32-analysis.cc
diff --git a/src/hydrogen-uint32-analysis.cc b/src/hydrogen-uint32-analysis.cc
index d796b37e789382e59b8c02a6175783f46464b375..67219f55dff778f78e9c4a02205cf6064ebdfe64 100644
--- a/src/hydrogen-uint32-analysis.cc
+++ b/src/hydrogen-uint32-analysis.cc
@@ -213,7 +213,11 @@ void HUint32AnalysisPhase::Run() {
// Analyze instruction and mark it with kUint32 if all
// its uses are uint32 safe.
HInstruction* current = uint32_instructions->at(i);
- if (Uint32UsesAreSafe(current)) current->SetFlag(HInstruction::kUint32);
+ if (current->IsLinked() &&
+ current->representation().IsInteger32() &&
+ Uint32UsesAreSafe(current)) {
+ current->SetFlag(HInstruction::kUint32);
+ }
}
// Some phis might have been optimistically marked with kUint32 flag.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698