Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 1837483003: Move base::FreeDeleter into its own header. (Closed)

Created:
4 years, 9 months ago by dcheng
Modified:
4 years, 9 months ago
Reviewers:
danakj, brettw
CC:
aboxhall+watch_chromium.org, cbentzel+watch_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, extensions-reviews_chromium.org, feature-media-reviews_chromium.org, gavinp+memory_chromium.org, halliwell+watch_chromium.org, jam, je_julie, kalyank, lcwu+watch_chromium.org, mlamouri+watch-geolocation_chromium.org, mmenke, Michael van Ouwerkerk, nektar+watch_chromium.org, ozone-reviews_chromium.org, rickyz+watch_chromium.org, tdresser+watch_chromium.org, wfh+watch_chromium.org, yuzo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move base::FreeDeleter into its own header. Final blocker to wholly deleting base/memory/scoped_ptr.h. BUG=554298 Committed: https://crrev.com/db5935f15f750739a5937e60e26b2ede16ba803d Cr-Commit-Position: refs/heads/master@{#383417}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -16 lines) Patch
M base/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M base/base.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M base/debug/stack_trace_posix.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M base/file_version_info_win.h View 1 chunk +1 line, -0 lines 0 comments Download
A base/memory/free_deleter.h View 1 chunk +25 lines, -0 lines 0 comments Download
M base/memory/scoped_ptr.h View 1 chunk +0 lines, -15 lines 1 comment Download
M base/memory/shared_memory_win_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M base/process/process_info_mac.cc View 1 chunk +1 line, -0 lines 0 comments Download
M base/security_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/api/braille_display_private/brlapi_connection.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/chrome_paths_mac.mm View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/service/cloud_print/cdd_conversion_win.h View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/service/cloud_print/cdd_conversion_win.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/service/cloud_print/print_system_win.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chromecast/base/bind_to_task_runner_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/exo/wayland/server.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/storage_monitor/storage_monitor_win_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/geolocation/wifi_data_provider_win.cc View 1 chunk +1 line, -0 lines 0 comments Download
M courgette/assembly_program.h View 1 chunk +1 line, -0 lines 0 comments Download
M device/hid/hid_service_win.cc View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/browser/api/cast_channel/cast_framer.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ipc/attachment_broker_mac_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M media/audio/alsa/alsa_output.cc View 1 chunk +1 line, -0 lines 0 comments Download
M media/audio/alsa/audio_manager_alsa.cc View 1 chunk +1 line, -0 lines 0 comments Download
M media/audio/mac/audio_manager_mac.cc View 1 chunk +1 line, -0 lines 0 comments Download
M media/base/bind_to_current_loop_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/base/io_buffer.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/cert/cert_verify_proc_win.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/cert/x509_cert_types_win.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/cert/x509_certificate_win.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/dns/address_sorter_win.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/dns/dns_config_service_win.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/dns/dns_config_service_win.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/dns/dns_config_service_win_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/proxy/dhcp_proxy_script_adapter_fetcher_win.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/proxy/dhcp_proxy_script_fetcher_win.cc View 1 chunk +1 line, -0 lines 0 comments Download
M printing/backend/print_backend_win.cc View 1 chunk +1 line, -0 lines 0 comments Download
M printing/backend/win_helper.h View 1 chunk +1 line, -0 lines 0 comments Download
M printing/backend/win_helper.cc View 1 chunk +1 line, -0 lines 0 comments Download
M printing/printing_context_win.cc View 1 chunk +1 line, -0 lines 0 comments Download
M sandbox/win/src/acl.h View 1 chunk +1 line, -0 lines 0 comments Download
M sandbox/win/src/acl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M sandbox/win/src/handle_closer.cc View 1 chunk +1 line, -0 lines 0 comments Download
M sandbox/win/src/process_policy_test.cc View 1 chunk +1 line, -0 lines 0 comments Download
M sandbox/win/src/process_thread_policy.cc View 1 chunk +1 line, -0 lines 0 comments Download
M sandbox/win/src/target_process.h View 1 chunk +1 line, -0 lines 0 comments Download
M sandbox/win/src/target_process.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/events/ozone/layout/xkb/xkb_keyboard_layout_engine.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/events/ozone/layout/xkb/xkb_keyboard_layout_engine.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gfx/win/physical_size.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
dcheng
+danakj@ for //base changes, +brettw for global OWNERS stamp
4 years, 9 months ago (2016-03-25 21:58:15 UTC) #2
dcheng
https://codereview.chromium.org/1837483003/diff/1/base/memory/scoped_ptr.h File base/memory/scoped_ptr.h (right): https://codereview.chromium.org/1837483003/diff/1/base/memory/scoped_ptr.h#newcode95 base/memory/scoped_ptr.h:95: #include <stdlib.h> FYI, I'm planning on cleaning this up ...
4 years, 9 months ago (2016-03-25 21:59:37 UTC) #3
danakj
LGTM!
4 years, 9 months ago (2016-03-25 22:01:10 UTC) #4
brettw
rs lgtm
4 years, 9 months ago (2016-03-25 22:09:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1837483003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1837483003/1
4 years, 9 months ago (2016-03-25 22:09:51 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-26 00:16:37 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-26 00:18:13 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/db5935f15f750739a5937e60e26b2ede16ba803d
Cr-Commit-Position: refs/heads/master@{#383417}

Powered by Google App Engine
This is Rietveld 408576698