third_party/WebKit/Source/core/html/HTMLSelectElement.h - Issue 1837463002: Improve conformance of default OPTION selection of SELECT element

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLSelectElement.h

Issue 1837463002: Improve conformance of default OPTION selection of SELECT element (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Renaming to resetToDefaultSelection Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLOptionElement.cpp ('k') | third_party/WebKit/Source/core/html/HTMLSelectElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/HTMLSelectElement.h

diff --git a/third_party/WebKit/Source/core/html/HTMLSelectElement.h b/third_party/WebKit/Source/core/html/HTMLSelectElement.h

index 4f561da24bf46ac8b0aa3e27cdcbb522d3d944e0..b02ce2efa19775ae03d926641d68699be889b339 100644

--- a/third_party/WebKit/Source/core/html/HTMLSelectElement.h

+++ b/third_party/WebKit/Source/core/html/HTMLSelectElement.h

@@ -91,7 +91,6 @@ public:

void setRecalcListItems();

void invalidateSelectedItems();

- void updateListItemSelectedStates();

using ListItems = WillBeHeapVector<RawPtrWillBeMember<HTMLElement>>;

const ListItems& listItems() const;

@@ -163,8 +162,6 @@ protected:

HTMLSelectElement(Document&, HTMLFormElement*);

private:

- void willRecalcStyle(StyleRecalcChange) override;

const AtomicString& formControlType() const override;

bool shouldShowFocusRingOnMouseFocus() const override;

@@ -195,8 +192,8 @@ private:

void dispatchInputAndChangeEventForMenuList();

- void recalcListItems(bool updateSelectedStates = true) const;

+ void recalcListItems() const;

+ void resetToDefaultSelection();

void typeAheadFind(KeyboardEvent*);

void saveLastSelection();

// Returns the first selected OPTION, or nullptr.