Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 1837443002: Specify some tests for 64-bit Windows 10. (Closed)

Created:
4 years, 9 months ago by Will Harris
Modified:
4 years, 8 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Specify some tests for 64-bit Windows 10. Depends on https://codereview.chromium.org/1830323005/ BUG=513354 Committed: https://crrev.com/f69d8723131dbb8f994b7c1c190a2969cdba5c71 Cr-Commit-Position: refs/heads/master@{#383877}

Patch Set 1 #

Patch Set 2 : use correct os dimension #

Patch Set 3 : more files #

Patch Set 4 : dimension probably is not needed #

Total comments: 2

Patch Set 5 : add missing builder #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -1 line) Patch
M testing/buildbot/chromium.win.json View 1 2 3 4 1 chunk +28 lines, -0 lines 0 comments Download
M tools/mb/mb_config.pyl View 1 2 3 4 3 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
Dirk Pranke
https://codereview.chromium.org/1837443002/diff/60001/tools/mb/mb_config.pyl File tools/mb/mb_config.pyl (right): https://codereview.chromium.org/1837443002/diff/60001/tools/mb/mb_config.pyl#newcode561 tools/mb/mb_config.pyl:561: 'Win8 GN (dbg)': 'gn_debug_bot_minimal_symbols_x86', Add a new 'Win10 Tests ...
4 years, 8 months ago (2016-03-28 22:19:10 UTC) #3
Will Harris
changes made. PTAL. https://codereview.chromium.org/1837443002/diff/60001/tools/mb/mb_config.pyl File tools/mb/mb_config.pyl (right): https://codereview.chromium.org/1837443002/diff/60001/tools/mb/mb_config.pyl#newcode561 tools/mb/mb_config.pyl:561: 'Win8 GN (dbg)': 'gn_debug_bot_minimal_symbols_x86', On 2016/03/28 ...
4 years, 8 months ago (2016-03-29 22:42:22 UTC) #4
Dirk Pranke
lgtm.
4 years, 8 months ago (2016-03-29 22:45:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1837443002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1837443002/80001
4 years, 8 months ago (2016-03-29 22:47:42 UTC) #7
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 8 months ago (2016-03-30 00:23:45 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-03-30 00:25:40 UTC) #11
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/f69d8723131dbb8f994b7c1c190a2969cdba5c71
Cr-Commit-Position: refs/heads/master@{#383877}

Powered by Google App Engine
This is Rietveld 408576698