Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Issue 1837433002: ChannelMojo: Bind the channel TaskRunner to the right thread (Closed)

Created:
4 years, 9 months ago by Ken Rockot(use gerrit already)
Modified:
4 years, 9 months ago
Reviewers:
Sam McNally
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ChannelMojo: Bind the channel TaskRunner to the right thread In some cases ChannelMojo is constructed on a different thread from the one used for IPC. Instead of capturing the channel's IPC task runner at construction time, capture it on Connect(), which is always called on the IPC thread. BUG=597615 R=sammc@chromium.org Committed: https://crrev.com/c18f64fce262d15e3f226660e6f1b9e68da54398 Cr-Commit-Position: refs/heads/master@{#383246}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M ipc/mojo/ipc_channel_mojo.cc View 3 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Ken Rockot(use gerrit already)
4 years, 9 months ago (2016-03-25 02:46:58 UTC) #1
Sam McNally
lgtm
4 years, 9 months ago (2016-03-25 02:51:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1837433002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1837433002/1
4 years, 9 months ago (2016-03-25 02:54:11 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-25 04:49:34 UTC) #5
commit-bot: I haz the power
4 years, 9 months ago (2016-03-25 04:52:20 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c18f64fce262d15e3f226660e6f1b9e68da54398
Cr-Commit-Position: refs/heads/master@{#383246}

Powered by Google App Engine
This is Rietveld 408576698