Implement MediaCaptureDevices.

Implement MediaCaptureDevices.

- Added MediaCaptureDevices to cache the MediaCaptureDevice in content layer.
- Removed the correspoding methods in MediaObserver.
- Removed the MediaDevicesMonitor APIs.

BUG=348867
TBR=mnissler

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=257198

[michaelbai, 2014-03-04 21:41:50]

@jam for content, sergeyu@ for chrome/browser/media

[jam, 2014-03-05 08:45:04]

just looked at content/public to start

https://codereview.chromium.org/183743021/diff/20001/content/public/browser/m...
File content/public/browser/media_capture_devices.h (right):

https://codereview.chromium.org/183743021/diff/20001/content/public/browser/m...
content/public/browser/media_capture_devices.h:16: class Observer {
i probably wasn't clear in the email thread, sorry. i had meant don't add this
observer here, and keep these callbacks on MediaObserver. The reason being is
that we don't need two similar media observer interfaces, plus their
accompanying registration methods

however these callbacks on MediaObserver should drop their parameters and just
act as notifiers only. the list can then be queried from here. this is to avoid
having the data being available in two different ways

https://codereview.chromium.org/183743021/diff/20001/content/public/browser/m...
content/public/browser/media_capture_devices.h:43: virtual void
SetAudioCaptureDevices(const MediaStreamDevices& devices) = 0;
these test methods are called by chrome to fake the devices that content gives
it. why not keep these testing hooks contained in chrome? i.e. the chrome side
which calls content can have override methods.

[michaelbai, 2014-03-05 20:02:40]

sergeyu@, you may hold on review, as jam@ comment on patch#1, there will not too
many change for chrome/browser/media, please review my next patch.

[michaelbai, 2014-03-05 21:55:45]

PTAL

https://codereview.chromium.org/183743021/diff/20001/content/public/browser/m...
File content/public/browser/media_capture_devices.h (right):

https://codereview.chromium.org/183743021/diff/20001/content/public/browser/m...
content/public/browser/media_capture_devices.h:16: class Observer {
On 2014/03/05 08:45:04, jam wrote:
> i probably wasn't clear in the email thread, sorry. i had meant don't add this
> observer here, and keep these callbacks on MediaObserver. The reason being is
> that we don't need two similar media observer interfaces, plus their
> accompanying registration methods
> 
> however these callbacks on MediaObserver should drop their parameters and just
> act as notifiers only. the list can then be queried from here. this is to
avoid
> having the data being available in two different ways

Done.

https://codereview.chromium.org/183743021/diff/20001/content/public/browser/m...
content/public/browser/media_capture_devices.h:43: virtual void
SetAudioCaptureDevices(const MediaStreamDevices& devices) = 0;
On 2014/03/05 08:45:04, jam wrote:
> these test methods are called by chrome to fake the devices that content gives
> it. why not keep these testing hooks contained in chrome? i.e. the chrome side
> which calls content can have override methods.

Done.

[jiayl, 2014-03-05 22:48:27]

https://codereview.chromium.org/183743021/diff/60001/chrome/browser/media/med...
File chrome/browser/media/media_capture_devices_dispatcher.cc (right):

https://codereview.chromium.org/183743021/diff/60001/chrome/browser/media/med...
chrome/browser/media/media_capture_devices_dispatcher.cc:733:
OnUpdateAudioDevices(GetAudioCaptureDevices()));
The result can be cached to avoid calling it once for every observer.

https://codereview.chromium.org/183743021/diff/60001/chrome/browser/media/med...
chrome/browser/media/media_capture_devices_dispatcher.cc:738:
OnUpdateVideoDevices(GetVideoCaptureDevices()));
dito.

[jam, 2014-03-06 01:40:38]

content lgtm with comments

https://codereview.chromium.org/183743021/diff/60001/content/public/browser/m...
File content/public/browser/media_capture_devices.h (right):

https://codereview.chromium.org/183743021/diff/60001/content/public/browser/m...
content/public/browser/media_capture_devices.h:13: // observer interface to
notify the change of devices.
nit: remove the second part of this comment

https://codereview.chromium.org/183743021/diff/60001/content/public/browser/m...
content/public/browser/media_capture_devices.h:22: 
let's move the one method from content/public/browser/media_devices_monitor.h
here and remove that file

[michaelbai, 2014-03-06 05:24:52]

PTAL,  wjia@ for content/browser/render_host/media/

https://codereview.chromium.org/183743021/diff/60001/chrome/browser/media/med...
File chrome/browser/media/media_capture_devices_dispatcher.cc (right):

https://codereview.chromium.org/183743021/diff/60001/chrome/browser/media/med...
chrome/browser/media/media_capture_devices_dispatcher.cc:733:
OnUpdateAudioDevices(GetAudioCaptureDevices()));
On 2014/03/05 22:48:27, jiayl wrote:
> The result can be cached to avoid calling it once for every observer.

Done.

https://codereview.chromium.org/183743021/diff/60001/chrome/browser/media/med...
chrome/browser/media/media_capture_devices_dispatcher.cc:738:
OnUpdateVideoDevices(GetVideoCaptureDevices()));
On 2014/03/05 22:48:27, jiayl wrote:
> dito.

Done.

https://codereview.chromium.org/183743021/diff/60001/content/public/browser/m...
File content/public/browser/media_capture_devices.h (right):

https://codereview.chromium.org/183743021/diff/60001/content/public/browser/m...
content/public/browser/media_capture_devices.h:13: // observer interface to
notify the change of devices.
On 2014/03/06 01:40:38, jam wrote:
> nit: remove the second part of this comment

Done.

https://codereview.chromium.org/183743021/diff/60001/content/public/browser/m...
content/public/browser/media_capture_devices.h:22: 
The head file was removed, and the method is in media_capture_devices_impl.cc
now.

On 2014/03/06 01:40:38, jam wrote:
> let's move the one method from content/public/browser/media_devices_monitor.h
> here and remove that file

[Sergey Ulanov, 2014-03-06 08:26:40]

https://codereview.chromium.org/183743021/diff/80001/content/browser/renderer...
File content/browser/renderer_host/media/media_capture_devices_impl.h (right):

https://codereview.chromium.org/183743021/diff/80001/content/browser/renderer...
content/browser/renderer_host/media/media_capture_devices_impl.h:1: // Copyright
(c) 2014 The Chromium Authors. All rights reserved.
nit: don't need (c)

https://codereview.chromium.org/183743021/diff/80001/content/browser/renderer...
content/browser/renderer_host/media/media_capture_devices_impl.h:9: #include
"base/observer_list.h"
this header is not used.

https://codereview.chromium.org/183743021/diff/80001/content/browser/renderer...
content/browser/renderer_host/media/media_capture_devices_impl.h:17: static
MediaCaptureDevicesImpl* GetInstance();
Is this necessary, given that there is MediaCaptureDevices::GetInstance()?

https://codereview.chromium.org/183743021/diff/80001/content/public/browser/m...
File content/public/browser/media_capture_devices.h (right):

https://codereview.chromium.org/183743021/diff/80001/content/public/browser/m...
content/public/browser/media_capture_devices.h:12: // This is a singleton class,
used to get Audio/Video devices.
Please mention that it must be used on the UI thread.

https://codereview.chromium.org/183743021/diff/80001/content/public/browser/m...
content/public/browser/media_capture_devices.h:13: CONTENT_EXPORT class
MediaCaptureDevices {
CONTENT_EXPORT should be between 'class' and the class name.

https://codereview.chromium.org/183743021/diff/80001/content/public/browser/m...
content/public/browser/media_capture_devices.h:13: CONTENT_EXPORT class
MediaCaptureDevices {
Does this class need to be be a singleton? E.g. can it be stored in
MediaStreamManager? If not, them maybe rename it to make it clear it's a
singleton, e.g. MediaCaptureDevicesCache.

[michaelbai, 2014-03-06 19:27:19]

PTAL

https://codereview.chromium.org/183743021/diff/80001/content/browser/renderer...
File content/browser/renderer_host/media/media_capture_devices_impl.h (right):

https://codereview.chromium.org/183743021/diff/80001/content/browser/renderer...
content/browser/renderer_host/media/media_capture_devices_impl.h:1: // Copyright
(c) 2014 The Chromium Authors. All rights reserved.
On 2014/03/06 08:26:40, Sergey Ulanov wrote:
> nit: don't need (c)

Done.

https://codereview.chromium.org/183743021/diff/80001/content/browser/renderer...
content/browser/renderer_host/media/media_capture_devices_impl.h:9: #include
"base/observer_list.h"
On 2014/03/06 08:26:40, Sergey Ulanov wrote:
> this header is not used.

Done.

https://codereview.chromium.org/183743021/diff/80001/content/browser/renderer...
content/browser/renderer_host/media/media_capture_devices_impl.h:17: static
MediaCaptureDevicesImpl* GetInstance();
Yes, it is required by Singleton<> implementation.

On 2014/03/06 08:26:40, Sergey Ulanov wrote:
> Is this necessary, given that there is MediaCaptureDevices::GetInstance()?

https://codereview.chromium.org/183743021/diff/80001/content/public/browser/m...
File content/public/browser/media_capture_devices.h (right):

https://codereview.chromium.org/183743021/diff/80001/content/public/browser/m...
content/public/browser/media_capture_devices.h:12: // This is a singleton class,
used to get Audio/Video devices.
On 2014/03/06 08:26:40, Sergey Ulanov wrote:
> Please mention that it must be used on the UI thread.

Done.

https://codereview.chromium.org/183743021/diff/80001/content/public/browser/m...
content/public/browser/media_capture_devices.h:13: CONTENT_EXPORT class
MediaCaptureDevices {
On 2014/03/06 08:26:40, Sergey Ulanov wrote:
> CONTENT_EXPORT should be between 'class' and the class name.

Done.

https://codereview.chromium.org/183743021/diff/80001/content/public/browser/m...
content/public/browser/media_capture_devices.h:13: CONTENT_EXPORT class
MediaCaptureDevices {

MediaStreamManager is not content API, browser can't access MediaCaptureDevices
from it; To make a singletone is reasonable, it has all devices information of a
system, and shouldn't have second instance, I think MediaCaptureDevices is also
a good name, this class do have a list of devices. 

On 2014/03/06 08:26:40, Sergey Ulanov wrote:
> Does this class need to be be a singleton? E.g. can it be stored in
> MediaStreamManager? If not, them maybe rename it to make it clear it's a
> singleton, e.g. MediaCaptureDevicesCache.

[Sergey Ulanov, 2014-03-07 02:58:35]

lgtm

[wjia(left Chromium), 2014-03-07 04:32:43]

https://codereview.chromium.org/183743021/diff/150001/content/browser/rendere...
File content/browser/renderer_host/media/media_capture_devices_impl.cc (right):

https://codereview.chromium.org/183743021/diff/150001/content/browser/rendere...
content/browser/renderer_host/media/media_capture_devices_impl.cc:56:
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
Do you really need this restriction? It seems this function and the video one
can be called on any thread.

https://codereview.chromium.org/183743021/diff/150001/content/browser/rendere...
File content/browser/renderer_host/media/media_capture_devices_impl.h (right):

https://codereview.chromium.org/183743021/diff/150001/content/browser/rendere...
content/browser/renderer_host/media/media_capture_devices_impl.h:31: // Called
by the MediaObserver() functions, executed on UI thread.
This comment doesn't match the context here.

[michaelbai, 2014-03-07 06:59:30]

PTAL

https://codereview.chromium.org/183743021/diff/150001/content/browser/rendere...
File content/browser/renderer_host/media/media_capture_devices_impl.cc (right):

https://codereview.chromium.org/183743021/diff/150001/content/browser/rendere...
content/browser/renderer_host/media/media_capture_devices_impl.cc:56:
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
On 2014/03/07 04:32:43, wjia wrote:
> Do you really need this restriction? It seems this function and the video one
> can be called on any thread.

Done.

https://codereview.chromium.org/183743021/diff/150001/content/browser/rendere...
File content/browser/renderer_host/media/media_capture_devices_impl.h (right):

https://codereview.chromium.org/183743021/diff/150001/content/browser/rendere...
content/browser/renderer_host/media/media_capture_devices_impl.h:31: // Called
by the MediaObserver() functions, executed on UI thread.
On 2014/03/07 04:32:43, wjia wrote:
> This comment doesn't match the context here.

Done.

[wjia(left Chromium), 2014-03-07 15:15:55]

lgtm

[michaelbai, 2014-03-07 20:10:02]

The CQ bit was checked by michaelbai@chromium.org

[commit-bot: I haz the power, 2014-03-07 20:34:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/michaelbai@chromium.org/183743021/210001

[commit-bot: I haz the power, 2014-03-08 10:56:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/michaelbai@chromium.org/183743021/210001

[commit-bot: I haz the power, 2014-03-08 12:01:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-08 12:01:49]

Try jobs failed on following builders: linux_chromium_chromeos_clang_dbg

[michaelbai, 2014-03-12 19:08:03]

The CQ bit was checked by michaelbai@chromium.org

[commit-bot: I haz the power, 2014-03-12 19:11:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/michaelbai@chromium.org/183743021/210001

[commit-bot: I haz the power, 2014-03-12 19:11:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-12 19:11:26]

Failed to apply patch for
chrome/browser/media/media_capture_devices_dispatcher.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file chrome/browser/media/media_capture_devices_dispatcher.cc
  Hunk #1 succeeded at 25 (offset -1 lines).
  Hunk #2 succeeded at 51 with fuzz 1 (offset 7 lines).
  Hunk #3 FAILED at 204.
  Hunk #4 succeeded at 289 (offset 43 lines).
  Hunk #5 succeeded at 729 (offset 38 lines).
  Hunk #6 succeeded at 808 (offset 64 lines).
  Hunk #7 succeeded at 911 (offset 74 lines).
  1 out of 7 hunks FAILED -- saving rejects to file
chrome/browser/media/media_capture_devices_dispatcher.cc.rej

Patch:       chrome/browser/media/media_capture_devices_dispatcher.cc
Index: chrome/browser/media/media_capture_devices_dispatcher.cc
diff --git a/chrome/browser/media/media_capture_devices_dispatcher.cc
b/chrome/browser/media/media_capture_devices_dispatcher.cc
index
2bafec2081625e6d08f0c00f71fe6c78fa3e39bf..8a84f902aa0fd5fae6bf70773712a85d866b5d86
100644
--- a/chrome/browser/media/media_capture_devices_dispatcher.cc
+++ b/chrome/browser/media/media_capture_devices_dispatcher.cc
@@ -26,7 +26,7 @@
 #include "components/user_prefs/pref_registry_syncable.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/desktop_media_id.h"
-#include "content/public/browser/media_devices_monitor.h"
+#include "content/public/browser/media_capture_devices.h"
 #include "content/public/browser/notification_service.h"
 #include "content/public/browser/notification_source.h"
 #include "content/public/browser/notification_types.h"
@@ -44,6 +44,7 @@
 #endif  //  defined(OS_CHROMEOS)
 
 using content::BrowserThread;
+using content::MediaCaptureDevices;
 using content::MediaStreamDevices;
 
 namespace {
@@ -203,8 +204,7 @@ MediaCaptureDevicesDispatcher*
MediaCaptureDevicesDispatcher::GetInstance() {
 }
 
 MediaCaptureDevicesDispatcher::MediaCaptureDevicesDispatcher()
-    : devices_enumerated_(false),
-      is_device_enumeration_disabled_(false),
+    : is_device_enumeration_disabled_(false),
       media_stream_capture_indicator_(new MediaStreamCaptureIndicator()),
       audio_stream_indicator_(new AudioStreamIndicator()) {
   // MediaCaptureDevicesDispatcher is a singleton. It should be created on
@@ -245,21 +245,19 @@ void
MediaCaptureDevicesDispatcher::RemoveObserver(Observer* observer) {
 const MediaStreamDevices&
 MediaCaptureDevicesDispatcher::GetAudioCaptureDevices() {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
-  if (!is_device_enumeration_disabled_ && !devices_enumerated_) {
-    content::EnsureMonitorCaptureDevices();
-    devices_enumerated_ = true;
-  }
-  return audio_devices_;
+  if (is_device_enumeration_disabled_)
+    return test_audio_devices_;
+
+  return MediaCaptureDevices::GetInstance()->GetAudioCaptureDevices();
 }
 
 const MediaStreamDevices&
 MediaCaptureDevicesDispatcher::GetVideoCaptureDevices() {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
-  if (!is_device_enumeration_disabled_ && !devices_enumerated_) {
-    content::EnsureMonitorCaptureDevices();
-    devices_enumerated_ = true;
-  }
-  return video_devices_;
+  if (is_device_enumeration_disabled_)
+    return test_video_devices_;
+
+  return MediaCaptureDevices::GetInstance()->GetVideoCaptureDevices();
 }
 
 void MediaCaptureDevicesDispatcher::Observe(
@@ -692,22 +690,22 @@ MediaCaptureDevicesDispatcher::GetDesktopStreamsRegistry()
{
   return desktop_streams_registry_.get();
 }
 
-void MediaCaptureDevicesDispatcher::OnAudioCaptureDevicesChanged(
-    const content::MediaStreamDevices& devices) {
+void MediaCaptureDevicesDispatcher::OnAudioCaptureDevicesChanged() {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
   BrowserThread::PostTask(
       BrowserThread::UI, FROM_HERE,
-      base::Bind(&MediaCaptureDevicesDispatcher::UpdateAudioDevicesOnUIThread,
-                 base::Unretained(this), devices));
+      base::Bind(
+          &MediaCaptureDevicesDispatcher::NotifyAudioDevicesChangedOnUIThread,
+          base::Unretained(this)));
 }
 
-void MediaCaptureDevicesDispatcher::OnVideoCaptureDevicesChanged(
-    const content::MediaStreamDevices& devices) {
+void MediaCaptureDevicesDispatcher::OnVideoCaptureDevicesChanged() {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
   BrowserThread::PostTask(
       BrowserThread::UI, FROM_HERE,
-      base::Bind(&MediaCaptureDevicesDispatcher::UpdateVideoDevicesOnUIThread,
-                 base::Unretained(this), devices));
+      base::Bind(
+          &MediaCaptureDevicesDispatcher::NotifyVideoDevicesChangedOnUIThread,
+          base::Unretained(this)));
 }
 
 void MediaCaptureDevicesDispatcher::OnMediaRequestStateChanged(
@@ -745,22 +743,16 @@ void MediaCaptureDevicesDispatcher::OnCreatingAudioStream(
           base::Unretained(this), render_process_id, render_frame_id));
 }
 
-void MediaCaptureDevicesDispatcher::UpdateAudioDevicesOnUIThread(
-    const content::MediaStreamDevices& devices) {
-  DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
-  devices_enumerated_ = true;
-  audio_devices_ = devices;
+void MediaCaptureDevicesDispatcher::NotifyAudioDevicesChangedOnUIThread() {
+  MediaStreamDevices devices = GetAudioCaptureDevices();
   FOR_EACH_OBSERVER(Observer, observers_,
-                    OnUpdateAudioDevices(audio_devices_));
+                    OnUpdateAudioDevices(devices));
 }
 
-void MediaCaptureDevicesDispatcher::UpdateVideoDevicesOnUIThread(
-    const content::MediaStreamDevices& devices) {
-  DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
-  devices_enumerated_ = true;
-  video_devices_ = devices;
+void MediaCaptureDevicesDispatcher::NotifyVideoDevicesChangedOnUIThread() {
+  MediaStreamDevices devices = GetVideoCaptureDevices();
   FOR_EACH_OBSERVER(Observer, observers_,
-                    OnUpdateVideoDevices(video_devices_));
+                    OnUpdateVideoDevices(devices));
 }
 
 void MediaCaptureDevicesDispatcher::UpdateMediaRequestStateOnUIThread(
@@ -844,3 +836,14 @@ bool
MediaCaptureDevicesDispatcher::IsDesktopCaptureInProgress() {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
   return desktop_capture_sessions_.size() > 0;
 }
+
+
+void MediaCaptureDevicesDispatcher::SetTestAudioCaptureDevices(
+    const MediaStreamDevices& devices) {
+  test_audio_devices_ = devices;
+}
+
+void MediaCaptureDevicesDispatcher::SetTestVideoCaptureDevices(
+    const MediaStreamDevices& devices) {
+  test_video_devices_ = devices;
+}

[michaelbai, 2014-03-12 19:42:12]

The CQ bit was checked by michaelbai@chromium.org

[michaelbai, 2014-03-12 19:44:47]

The CQ bit was unchecked by michaelbai@chromium.org

[commit-bot: I haz the power, 2014-03-12 19:45:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/michaelbai@chromium.org/183743021/220001

[michaelbai, 2014-03-12 19:46:08]

The CQ bit was checked by michaelbai@chromium.org

[michaelbai, 2014-03-12 21:21:45]

The CQ bit was unchecked by michaelbai@chromium.org

[michaelbai, 2014-03-12 21:21:56]

The CQ bit was checked by michaelbai@chromium.org

[michaelbai, 2014-03-12 23:43:01]

The CQ bit was checked by michaelbai@chromium.org

[michaelbai, 2014-03-13 17:35:24]

The CQ bit was unchecked by michaelbai@chromium.org

[michaelbai, 2014-03-13 17:35:31]

The CQ bit was checked by michaelbai@chromium.org

[michaelbai, 2014-03-13 18:38:48]

The CQ bit was checked by michaelbai@chromium.org

[commit-bot: I haz the power, 2014-03-13 18:41:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/michaelbai@chromium.org/183743021/280001

[commit-bot: I haz the power, 2014-03-13 20:12:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-13 20:12:18]

Try jobs failed on following builders:
  tryserver.chromium on linux_chromium_rel

[michaelbai, 2014-03-13 21:09:52]

The CQ bit was checked by michaelbai@chromium.org

[commit-bot: I haz the power, 2014-03-13 21:11:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/michaelbai@chromium.org/183743021/300001

[commit-bot: I haz the power, 2014-03-13 22:44:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-13 22:44:20]

Try jobs failed on following builders:
  tryserver.chromium on linux_chromium_rel

[michaelbai, 2014-03-14 02:52:17]

The CQ bit was checked by michaelbai@chromium.org

[commit-bot: I haz the power, 2014-03-14 02:53:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/michaelbai@chromium.org/183743021/320001

[commit-bot: I haz the power, 2014-03-14 02:56:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-14 02:56:55]

Try jobs failed on following builders:
  tryserver.chromium on linux_chromium_clang_dbg

[michaelbai, 2014-03-14 04:39:03]

The CQ bit was checked by michaelbai@chromium.org

[commit-bot: I haz the power, 2014-03-14 04:39:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/michaelbai@chromium.org/183743021/320001

[commit-bot: I haz the power, 2014-03-14 04:40:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-14 04:40:32]

Try jobs failed on following builders:
  tryserver.chromium on linux_chromium_clang_dbg

[michaelbai, 2014-03-14 16:03:22]

The CQ bit was checked by michaelbai@chromium.org

[commit-bot: I haz the power, 2014-03-14 16:04:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/michaelbai@chromium.org/183743021/320001

[commit-bot: I haz the power, 2014-03-14 21:09:47]

Change committed as 257198