Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 183743018: Harmony: implement Math.cbrt in Javascript. (Closed)

Created:
6 years, 9 months ago by Yang
Modified:
6 years, 9 months ago
Reviewers:
Jarin
CC:
v8-dev
Visibility:
Public.

Description

Harmony: implement Math.cbrt in Javascript. R=jarin@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19742

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -33 lines) Patch
M src/harmony-math.js View 1 chunk +25 lines, -2 lines 0 comments Download
M src/runtime.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/runtime.cc View 1 chunk +0 lines, -30 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Yang
This CL depends on https://codereview.chromium.org/178583006/ for introducing %_DoubleHi and %_ConstructDouble.
6 years, 9 months ago (2014-03-04 16:02:04 UTC) #1
Jarin
lgtm
6 years, 9 months ago (2014-03-10 07:39:18 UTC) #2
Yang
6 years, 9 months ago (2014-03-10 08:21:25 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r19742 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698