Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 183743013: Rename Clipboard.idl to DataTransfer.idl to match the spec (Closed)

Created:
6 years, 9 months ago by arv (Not doing code reviews)
Modified:
6 years, 9 months ago
Reviewers:
tkent, sof, Inactive
CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, haraken, Nate Chapin, watchdog-blink-watchlist_google.com
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Rename Clipboard.idl to DataTransfer.idl to match the spec http://www.whatwg.org/specs/web-apps/current-work/multipage/dnd.html#the-datatransfer-interface The spec uses DataTransfer and both Firefox and IE agrees. BUG=348580 R=ch.dumez@samsung.com, tkent@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168494

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -57 lines) Patch
M LayoutTests/fast/dom/dom-constructors.html View 2 chunks +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/dom-constructors-expected.txt View 2 chunks +1 line, -1 line 0 comments Download
M LayoutTests/fast/events/drag-and-drop-set-drag-data-arguments.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/events/drag-and-drop-set-drag-data-arguments-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/virtual/stable/webexposed/global-constructors-listing-expected.txt View 2 chunks +1 line, -1 line 0 comments Download
M LayoutTests/webexposed/global-constructors-listing-expected.txt View 2 chunks +1 line, -1 line 0 comments Download
M Source/bindings/v8/custom/V8EventCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
D Source/core/clipboard/Clipboard.idl View 1 chunk +0 lines, -44 lines 0 comments Download
A + Source/core/clipboard/DataTransfer.idl View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/core.gypi View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/events/Event.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/events/MouseEvent.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (0 generated)
arv (Not doing code reviews)
2 questions. 1. I didn't rename the C++ files/classes. It can be done but I ...
6 years, 9 months ago (2014-03-03 16:39:38 UTC) #1
sof
On 2014/03/03 16:39:38, arv wrote: > 2 questions. > > 1. I didn't rename the ...
6 years, 9 months ago (2014-03-03 17:20:54 UTC) #2
Inactive
lgtm but this needs API Owner approval. On 2014/03/03 16:39:38, arv wrote: > 2 questions. ...
6 years, 9 months ago (2014-03-03 18:06:31 UTC) #3
tkent
lgtm. This change looks safe.
6 years, 9 months ago (2014-03-03 23:17:31 UTC) #4
tkent
I don't think we need to do 2.
6 years, 9 months ago (2014-03-03 23:18:32 UTC) #5
arv (Not doing code reviews)
The CQ bit was checked by arv@chromium.org
6 years, 9 months ago (2014-03-03 23:26:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/arv@chromium.org/183743013/20001
6 years, 9 months ago (2014-03-03 23:27:13 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-04 12:55:51 UTC) #8
commit-bot: I haz the power
Retried try job too often on win_layout for step(s) webkit_lint http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout&number=25384
6 years, 9 months ago (2014-03-04 12:55:51 UTC) #9
arv (Not doing code reviews)
The CQ bit was checked by arv@chromium.org
6 years, 9 months ago (2014-03-04 15:51:16 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/arv@chromium.org/183743013/20001
6 years, 9 months ago (2014-03-04 15:51:37 UTC) #11
arv (Not doing code reviews)
Committed patchset #1 manually as r6c112cc (presubmit successful).
6 years, 9 months ago (2014-03-04 23:22:01 UTC) #12
arv (Not doing code reviews)
On 2014/03/04 23:22:01, arv wrote: > Committed patchset #1 manually as r6c112cc (presubmit successful). This ...
6 years, 9 months ago (2014-03-05 15:47:02 UTC) #13
arv (Not doing code reviews)
6 years, 9 months ago (2014-03-05 16:02:01 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 manually as r168494 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698