Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 183743012: SVGFontFaceElement::removedFrom should not use FontSelector when document is not active. (Closed)

Created:
6 years, 9 months ago by tasak
Modified:
6 years, 9 months ago
CC:
blink-reviews, krit, fs, ed+blinkwatch_opera.com, f(malita), gyuyoung.kim_webkit.org, Stephen Chennney, pdr., rwlbuis, Kunihiko Sakamoto, kareng
Visibility:
Public.

Description

SVGFontFaceElement::removedFrom should not use FontSelector when document is not active. BUG=348401 TEST=fast/css/use-incorrect-svg-crash.html TBR=morrita@chromium.org, dglazkov@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168271

Patch Set 1 #

Total comments: 1

Patch Set 2 : Added comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -0 lines) Patch
A LayoutTests/fast/css/resources/incorrect-font.svg View 1 1 chunk +9 lines, -0 lines 0 comments Download
A LayoutTests/fast/css/use-incorrect-svg-crash.html View 1 chunk +16 lines, -0 lines 0 comments Download
A + LayoutTests/fast/css/use-incorrect-svg-crash-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/core/svg/SVGFontFaceElement.cpp View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
tasak
6 years, 9 months ago (2014-03-03 04:31:49 UTC) #1
kouhei (in TOK)
nullchecking add lgtm with nits.
6 years, 9 months ago (2014-03-03 04:33:20 UTC) #2
kouhei (in TOK)
https://codereview.chromium.org/183743012/diff/1/LayoutTests/fast/css/resources/incorrect-font.svg File LayoutTests/fast/css/resources/incorrect-font.svg (right): https://codereview.chromium.org/183743012/diff/1/LayoutTests/fast/css/resources/incorrect-font.svg#newcode1 LayoutTests/fast/css/resources/incorrect-font.svg:1: <?xml version="1.0" standalone="no"?> Would you add a comment where ...
6 years, 9 months ago (2014-03-03 04:33:28 UTC) #3
kouhei (in TOK)
Additional comments lgtm.
6 years, 9 months ago (2014-03-03 04:53:47 UTC) #4
tasak
+morrita Would you tell me about whether imported documents can be active or not?
6 years, 9 months ago (2014-03-03 04:56:44 UTC) #5
tasak
+haraken Would you review this CL? I need to land this patch as soon as ...
6 years, 9 months ago (2014-03-03 05:05:20 UTC) #6
haraken
Given the urgency, rubberstamp LGTM. I'd like to have dimitri and morrita-san to take a ...
6 years, 9 months ago (2014-03-03 05:08:01 UTC) #7
tasak
On 2014/03/03 05:08:01, haraken wrote: > Given the urgency, rubberstamp LGTM. > > I'd like ...
6 years, 9 months ago (2014-03-03 05:10:20 UTC) #8
tasak
The CQ bit was checked by tasak@google.com
6 years, 9 months ago (2014-03-03 05:10:26 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tasak@google.com/183743012/20001
6 years, 9 months ago (2014-03-03 05:10:34 UTC) #10
commit-bot: I haz the power
6 years, 9 months ago (2014-03-03 07:33:23 UTC) #11
Message was sent while issue was closed.
Change committed as 168271

Powered by Google App Engine
This is Rietveld 408576698