Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 183743010: Fix the git-svn remote for the depot_tools and nacl recipes. (Closed)

Created:
6 years, 9 months ago by Primiano Tucci (use gerrit)
Modified:
6 years, 9 months ago
Reviewers:
agable, Torne, iannucci
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org, Torne
Visibility:
Public.

Description

Fix the git-svn remote for the depot_tools and nacl recipes. The depot_tools and nacl recipes aren't setting up git-svn properly. There is no git-svn branch in the git mirror for depot-tools and nacl, just master. As a consequence "fetch depot-tools" ends up recreating all the objects from svn taking much more time than it should. BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=254506

Patch Set 1 #

Patch Set 2 : nacl #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M recipes/depot_tools.py View 1 chunk +1 line, -1 line 0 comments Download
M recipes/nacl.py View 1 1 chunk +1 line, -1 line 0 comments Download
M recipes/naclports.py View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Primiano Tucci (use gerrit)
6 years, 9 months ago (2014-02-28 14:11:56 UTC) #1
Torne
LGTM, but I'm not an owner.
6 years, 9 months ago (2014-02-28 14:13:03 UTC) #2
Primiano Tucci (use gerrit)
+agable
6 years, 9 months ago (2014-03-03 09:47:39 UTC) #3
agable
lgtm
6 years, 9 months ago (2014-03-03 18:21:15 UTC) #4
Primiano Tucci (use gerrit)
The CQ bit was checked by primiano@chromium.org
6 years, 9 months ago (2014-03-03 18:32:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/primiano@chromium.org/183743010/20001
6 years, 9 months ago (2014-03-03 18:32:29 UTC) #6
commit-bot: I haz the power
6 years, 9 months ago (2014-03-03 18:34:29 UTC) #7
Message was sent while issue was closed.
Change committed as 254506

Powered by Google App Engine
This is Rietveld 408576698