third_party/WebKit/LayoutTests/css-parser/content-parsing-invalid.html - Issue 1837413002: Ensure that we don't allow 'none' alongside other values in content property

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/css-parser/content-parsing-invalid.html

Issue 1837413002: Ensure that we don't allow 'none' alongside other values in content property (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/css-parser/content-parsing.html ('K') | « third_party/WebKit/LayoutTests/css-parser/content-parsing.html ('k') | third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp » ('j') | third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!doctype html>	1 <!doctype html>

2 <script src="../resources/testharness.js"></script>	2 <script src="../resources/testharness.js"></script>

3 <script src="../resources/testharnessreport.js"></script>	3 <script src="../resources/testharnessreport.js"></script>

4	4

5 <style>	5 <style>

6 #target::before {	6 #target1::before {

7 content: normal normal;	7 content: normal normal;

8 }	8 }

9 #target::after {	9 #target1::after {

10 content: normal normal;	10 content: normal normal;

11 }	11 }

	12

	13 #target2::before {

	14 content: none normal;
	Timothy Loh 2016/03/30 02:53:28 It'd make more sense to test something like none o It'd make more sense to test something like none open-quote or url("a") none. Prior to this patch, this test would pass anyway. nainar 2016/03/30 03:27:36 Done. Done.
	15 }

	16 #target2::after {

	17 content: none normal;

	18 }

12 </style>	19 </style>

13	20

14 <div id="target"></div>	21 <div id="target1"></div>

	22 <div id="target2"></div>

15	23

16 <script>	24 <script>

17 test(function(){	25 test(function(){

18 assert_equals(getComputedStyle(target, '::before').content, '');	26 assert_equals(getComputedStyle(target1, '::before').content, '');
	Timothy Loh 2016/03/30 02:53:28 btw I was too lazy to whine about this previously btw I was too lazy to whine about this previously but it'd be better to test this by check document.styleSheets[0].cssRules[0].style.content and similar. getComputedStyle requires more of the pipeline than we should depend on for a test like this. This way you won't end up needing to change it in the other patch... nainar 2016/03/30 03:27:36 Done. Done.
19 assert_equals(getComputedStyle(target, '::after').content, '');	27 assert_equals(getComputedStyle(target1, '::after').content, '');

	28 assert_equals(getComputedStyle(target2, '::before').content, '');

	29 assert_equals(getComputedStyle(target2, '::after').content, '');

20 }, "Test to ensure that invalid values of content on pseudo elements are dropped by the parser");	30 }, "Test to ensure that invalid values of content on pseudo elements are dropped by the parser");

21 </script>	31 </script>

OLD	NEW